When qemu_set_log_filename() detects an invalid file name, it reports an error, closes the log file (if any), and starts logging to stderr (unless daemonized or nothing is being logged). This is wrong. Asking for an invalid log file on the command line should be fatal. Asking for one in the monitor should fail without messing up an existing logfile. Fix by converting qemu_set_log_filename() to Error. Pass it &error_fatal, except for hmp_logfile report errors. This also permits testing without a subprocess, so do that. Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <1466011636-6112-4-git-send-email-armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com>
125 lines
3.3 KiB
C
125 lines
3.3 KiB
C
#ifndef QEMU_LOG_H
|
|
#define QEMU_LOG_H
|
|
|
|
|
|
/* Private global variables, don't use */
|
|
extern FILE *qemu_logfile;
|
|
extern int qemu_loglevel;
|
|
|
|
/*
|
|
* The new API:
|
|
*
|
|
*/
|
|
|
|
/* Log settings checking macros: */
|
|
|
|
/* Returns true if qemu_log() will really write somewhere
|
|
*/
|
|
static inline bool qemu_log_enabled(void)
|
|
{
|
|
return qemu_logfile != NULL;
|
|
}
|
|
|
|
/* Returns true if qemu_log() will write somewhere else than stderr
|
|
*/
|
|
static inline bool qemu_log_separate(void)
|
|
{
|
|
return qemu_logfile != NULL && qemu_logfile != stderr;
|
|
}
|
|
|
|
#define CPU_LOG_TB_OUT_ASM (1 << 0)
|
|
#define CPU_LOG_TB_IN_ASM (1 << 1)
|
|
#define CPU_LOG_TB_OP (1 << 2)
|
|
#define CPU_LOG_TB_OP_OPT (1 << 3)
|
|
#define CPU_LOG_INT (1 << 4)
|
|
#define CPU_LOG_EXEC (1 << 5)
|
|
#define CPU_LOG_PCALL (1 << 6)
|
|
#define CPU_LOG_TB_CPU (1 << 8)
|
|
#define CPU_LOG_RESET (1 << 9)
|
|
#define LOG_UNIMP (1 << 10)
|
|
#define LOG_GUEST_ERROR (1 << 11)
|
|
#define CPU_LOG_MMU (1 << 12)
|
|
#define CPU_LOG_TB_NOCHAIN (1 << 13)
|
|
#define CPU_LOG_PAGE (1 << 14)
|
|
#define LOG_TRACE (1 << 15)
|
|
|
|
/* Returns true if a bit is set in the current loglevel mask
|
|
*/
|
|
static inline bool qemu_loglevel_mask(int mask)
|
|
{
|
|
return (qemu_loglevel & mask) != 0;
|
|
}
|
|
|
|
/* Logging functions: */
|
|
|
|
/* main logging function
|
|
*/
|
|
void GCC_FMT_ATTR(1, 2) qemu_log(const char *fmt, ...);
|
|
|
|
/* vfprintf-like logging function
|
|
*/
|
|
static inline void GCC_FMT_ATTR(1, 0)
|
|
qemu_log_vprintf(const char *fmt, va_list va)
|
|
{
|
|
if (qemu_logfile) {
|
|
vfprintf(qemu_logfile, fmt, va);
|
|
}
|
|
}
|
|
|
|
/* log only if a bit is set on the current loglevel mask:
|
|
* @mask: bit to check in the mask
|
|
* @fmt: printf-style format string
|
|
* @args: optional arguments for format string
|
|
*/
|
|
#define qemu_log_mask(MASK, FMT, ...) \
|
|
do { \
|
|
if (unlikely(qemu_loglevel_mask(MASK))) { \
|
|
qemu_log(FMT, ## __VA_ARGS__); \
|
|
} \
|
|
} while (0)
|
|
|
|
/* log only if a bit is set on the current loglevel mask
|
|
* and we are in the address range we care about:
|
|
* @mask: bit to check in the mask
|
|
* @addr: address to check in dfilter
|
|
* @fmt: printf-style format string
|
|
* @args: optional arguments for format string
|
|
*/
|
|
#define qemu_log_mask_and_addr(MASK, ADDR, FMT, ...) \
|
|
do { \
|
|
if (unlikely(qemu_loglevel_mask(MASK)) && \
|
|
qemu_log_in_addr_range(ADDR)) { \
|
|
qemu_log(FMT, ## __VA_ARGS__); \
|
|
} \
|
|
} while (0)
|
|
|
|
/* Maintenance: */
|
|
|
|
/* define log items */
|
|
typedef struct QEMULogItem {
|
|
int mask;
|
|
const char *name;
|
|
const char *help;
|
|
} QEMULogItem;
|
|
|
|
extern const QEMULogItem qemu_log_items[];
|
|
|
|
void qemu_set_log(int log_flags);
|
|
void qemu_log_needs_buffers(void);
|
|
void qemu_set_log_filename(const char *filename, Error **errp);
|
|
void qemu_set_dfilter_ranges(const char *ranges, Error **errp);
|
|
bool qemu_log_in_addr_range(uint64_t addr);
|
|
int qemu_str_to_log_mask(const char *str);
|
|
|
|
/* Print a usage message listing all the valid logging categories
|
|
* to the specified FILE*.
|
|
*/
|
|
void qemu_print_log_usage(FILE *f);
|
|
|
|
/* fflush() the log file */
|
|
void qemu_log_flush(void);
|
|
/* Close the log file */
|
|
void qemu_log_close(void);
|
|
|
|
#endif
|