678bcc3c2c
Code consuming the "crypto/tlscreds*.h" APIs doesn't need to access its internals. Move the structure definitions to the "tlscredspriv.h" private header (only accessible by implementations). The public headers (in include/) still forward-declare the structures typedef. Note, tlscreds.c and 3 of the 5 modified source files already include "tlscredspriv.h", so only add it to tls-cipher-suites.c and tlssession.c. Removing the internals from the public header solves a bug introduced by commit7de2e85653("yank: Unregister function when using TLS migration") which made migration/qemu-file-channel.c include "io/channel-tls.h", itself sometime depends on GNUTLS, leading to a build failure on OSX: [2/35] Compiling C object libmigration.fa.p/migration_qemu-file-channel.c.o FAILED: libmigration.fa.p/migration_qemu-file-channel.c.o cc -Ilibmigration.fa.p -I. -I.. -Iqapi [ ... ] -o libmigration.fa.p/migration_qemu-file-channel.c.o -c ../migration/qemu-file-channel.c In file included from ../migration/qemu-file-channel.c:29: In file included from include/io/channel-tls.h:26: In file included from include/crypto/tlssession.h:24: include/crypto/tlscreds.h:28:10: fatal error: 'gnutls/gnutls.h' file not found #include <gnutls/gnutls.h> ^~~~~~~~~~~~~~~~~ 1 error generated. Reported-by: Stefan Weil <sw@weilnetz.de> Suggested-by: Daniel P. Berrangé <berrange@redhat.com> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/407 Fixes:7de2e85653("yank: Unregister function when using TLS migration") Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
101 lines
3 KiB
C
101 lines
3 KiB
C
/*
|
|
* QEMU crypto TLS anonymous credential support
|
|
*
|
|
* Copyright (c) 2015 Red Hat, Inc.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#ifndef QCRYPTO_TLSCREDSANON_H
|
|
#define QCRYPTO_TLSCREDSANON_H
|
|
|
|
#include "crypto/tlscreds.h"
|
|
#include "qom/object.h"
|
|
|
|
#define TYPE_QCRYPTO_TLS_CREDS_ANON "tls-creds-anon"
|
|
typedef struct QCryptoTLSCredsAnon QCryptoTLSCredsAnon;
|
|
DECLARE_INSTANCE_CHECKER(QCryptoTLSCredsAnon, QCRYPTO_TLS_CREDS_ANON,
|
|
TYPE_QCRYPTO_TLS_CREDS_ANON)
|
|
|
|
|
|
typedef struct QCryptoTLSCredsAnonClass QCryptoTLSCredsAnonClass;
|
|
|
|
/**
|
|
* QCryptoTLSCredsAnon:
|
|
*
|
|
* The QCryptoTLSCredsAnon object provides a representation
|
|
* of anonymous credentials used perform a TLS handshake.
|
|
* This is primarily provided for backwards compatibility and
|
|
* its use is discouraged as it has poor security characteristics
|
|
* due to lacking MITM attack protection amongst other problems.
|
|
*
|
|
* This is a user creatable object, which can be instantiated
|
|
* via object_new_propv():
|
|
*
|
|
* <example>
|
|
* <title>Creating anonymous TLS credential objects in code</title>
|
|
* <programlisting>
|
|
* Object *obj;
|
|
* Error *err = NULL;
|
|
* obj = object_new_propv(TYPE_QCRYPTO_TLS_CREDS_ANON,
|
|
* "tlscreds0",
|
|
* &err,
|
|
* "endpoint", "server",
|
|
* "dir", "/path/x509/cert/dir",
|
|
* "verify-peer", "yes",
|
|
* NULL);
|
|
* </programlisting>
|
|
* </example>
|
|
*
|
|
* Or via QMP:
|
|
*
|
|
* <example>
|
|
* <title>Creating anonymous TLS credential objects via QMP</title>
|
|
* <programlisting>
|
|
* {
|
|
* "execute": "object-add", "arguments": {
|
|
* "id": "tlscreds0",
|
|
* "qom-type": "tls-creds-anon",
|
|
* "props": {
|
|
* "endpoint": "server",
|
|
* "dir": "/path/to/x509/cert/dir",
|
|
* "verify-peer": false
|
|
* }
|
|
* }
|
|
* }
|
|
* </programlisting>
|
|
* </example>
|
|
*
|
|
*
|
|
* Or via the CLI:
|
|
*
|
|
* <example>
|
|
* <title>Creating anonymous TLS credential objects via CLI</title>
|
|
* <programlisting>
|
|
* qemu-system-x86_64 -object tls-creds-anon,id=tlscreds0,\
|
|
* endpoint=server,verify-peer=off,\
|
|
* dir=/path/to/x509/certdir/
|
|
* </programlisting>
|
|
* </example>
|
|
*
|
|
*/
|
|
|
|
struct QCryptoTLSCredsAnonClass {
|
|
QCryptoTLSCredsClass parent_class;
|
|
};
|
|
|
|
|
|
#endif /* QCRYPTO_TLSCREDSANON_H */
|