8d999995e4
The existing implementation of the pending behavior in gic_set_irq,
gic_complete_irq, and the distributor pending set/clear registers does
not follow the semantics of the GICv2.0 specs, but may implement the
11MPCore support. Therefore, maintain the existing semantics for
11MPCore and v7M NVIC and change the behavior to be in accordance with
the GICv2.0 specs for "generic implementations" (s->revision == 1 ||
s->revision == 2).
Generic implementations distinguish between setting a level-triggered
interrupt pending through writes to the GICD_ISPENDR and when hardware
raises the interrupt line. Writing to the GICD_ICPENDR will not cause
the interrupt to become non-pending if the line is still active, and
conversely, if the line is deactivated but the interrupt is marked as
pending through a write to GICD_ISPENDR, the interrupt remains pending.
Handle this situation in the GIC_TEST_PENDING (which now becomes a
static inline named gic_test_pending) and let the 'pending' field
correspond only to the latched state of the D-flip flop in the GICv2.0
specs Figure 4-10.
The following changes are added:
gic_test_pending:
Make this a static inline and split out the 11MPCore from the generic
behavior. For the generic behavior, consider interrupts pending if:
((s->irq_state[irq].pending & (cm) != 0) ||
(!GIC_TEST_EDGE_TRIGGER(irq) && GIC_TEST_LEVEL(irq, cm))
gic_set_irq:
Split out the 11MPCore from the generic behavior. For the generic
behavior, always GIC_SET_LEVEL() on positive level, but only
GIC_SET_PENDING for edge-triggered interrupts and always simply
GIC_CLEAR_LEVEL() on negative level.
gic_complete_irq:
Only resample the line for line-triggered interrupts on an 11MPCore.
Generic implementations will sample the line directly in
gic_test_pending().
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
81 lines
3.5 KiB
C
81 lines
3.5 KiB
C
/*
|
|
* ARM GIC support - internal interfaces
|
|
*
|
|
* Copyright (c) 2012 Linaro Limited
|
|
* Written by Peter Maydell
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef QEMU_ARM_GIC_INTERNAL_H
|
|
#define QEMU_ARM_GIC_INTERNAL_H
|
|
|
|
#include "hw/intc/arm_gic.h"
|
|
|
|
#define ALL_CPU_MASK ((unsigned)(((1 << GIC_NCPU) - 1)))
|
|
|
|
/* The NVIC has 16 internal vectors. However these are not exposed
|
|
through the normal GIC interface. */
|
|
#define GIC_BASE_IRQ ((s->revision == REV_NVIC) ? 32 : 0)
|
|
|
|
#define GIC_SET_ENABLED(irq, cm) s->irq_state[irq].enabled |= (cm)
|
|
#define GIC_CLEAR_ENABLED(irq, cm) s->irq_state[irq].enabled &= ~(cm)
|
|
#define GIC_TEST_ENABLED(irq, cm) ((s->irq_state[irq].enabled & (cm)) != 0)
|
|
#define GIC_SET_PENDING(irq, cm) s->irq_state[irq].pending |= (cm)
|
|
#define GIC_CLEAR_PENDING(irq, cm) s->irq_state[irq].pending &= ~(cm)
|
|
#define GIC_SET_ACTIVE(irq, cm) s->irq_state[irq].active |= (cm)
|
|
#define GIC_CLEAR_ACTIVE(irq, cm) s->irq_state[irq].active &= ~(cm)
|
|
#define GIC_TEST_ACTIVE(irq, cm) ((s->irq_state[irq].active & (cm)) != 0)
|
|
#define GIC_SET_MODEL(irq) s->irq_state[irq].model = true
|
|
#define GIC_CLEAR_MODEL(irq) s->irq_state[irq].model = false
|
|
#define GIC_TEST_MODEL(irq) s->irq_state[irq].model
|
|
#define GIC_SET_LEVEL(irq, cm) s->irq_state[irq].level = (cm)
|
|
#define GIC_CLEAR_LEVEL(irq, cm) s->irq_state[irq].level &= ~(cm)
|
|
#define GIC_TEST_LEVEL(irq, cm) ((s->irq_state[irq].level & (cm)) != 0)
|
|
#define GIC_SET_EDGE_TRIGGER(irq) s->irq_state[irq].edge_trigger = true
|
|
#define GIC_CLEAR_EDGE_TRIGGER(irq) s->irq_state[irq].edge_trigger = false
|
|
#define GIC_TEST_EDGE_TRIGGER(irq) (s->irq_state[irq].edge_trigger)
|
|
#define GIC_GET_PRIORITY(irq, cpu) (((irq) < GIC_INTERNAL) ? \
|
|
s->priority1[irq][cpu] : \
|
|
s->priority2[(irq) - GIC_INTERNAL])
|
|
#define GIC_TARGET(irq) s->irq_target[irq]
|
|
|
|
/* The special cases for the revision property: */
|
|
#define REV_11MPCORE 0
|
|
#define REV_NVIC 0xffffffff
|
|
|
|
void gic_set_pending_private(GICState *s, int cpu, int irq);
|
|
uint32_t gic_acknowledge_irq(GICState *s, int cpu);
|
|
void gic_complete_irq(GICState *s, int cpu, int irq);
|
|
void gic_update(GICState *s);
|
|
void gic_init_irqs_and_distributor(GICState *s, int num_irq);
|
|
void gic_set_priority(GICState *s, int cpu, int irq, uint8_t val);
|
|
|
|
static inline bool gic_test_pending(GICState *s, int irq, int cm)
|
|
{
|
|
if (s->revision == REV_NVIC || s->revision == REV_11MPCORE) {
|
|
return s->irq_state[irq].pending & cm;
|
|
} else {
|
|
/* Edge-triggered interrupts are marked pending on a rising edge, but
|
|
* level-triggered interrupts are either considered pending when the
|
|
* level is active or if software has explicitly written to
|
|
* GICD_ISPENDR to set the state pending.
|
|
*/
|
|
return (s->irq_state[irq].pending & cm) ||
|
|
(!GIC_TEST_EDGE_TRIGGER(irq) && GIC_TEST_LEVEL(irq, cm));
|
|
}
|
|
}
|
|
|
|
#endif /* !QEMU_ARM_GIC_INTERNAL_H */
|