3bc97fd592
Right now, qmp-output-visitor happens to produce a QNull result if nothing is actually visited between the creation of the visitor and the request for the resulting QObject. A stronger protocol would require that a QMP output visit MUST visit something. But to still be able to produce a JSON 'null' output, we need a new visitor function that states our intentions. Yes, we could say that such a visit must go through visit_type_any(), but that feels clunky. So this patch introduces the new visit_type_null() interface and its no-op interface in the dealloc visitor, and stubs in the qmp visitors (the next patch will finish the implementation). For the visitors that will not implement the callback, document the situation. The code in qapi-visit-core unconditionally dereferences the callback pointer, so that a segfault will inform a developer if they need to implement the callback for their choice of visitor. Note that JSON has a primitive null type, with the single value null; likewise with the QNull type for QObject; but for QAPI, we just have the 'null' value without a null type. We may eventually want to add more support in QAPI for null (most likely, we'd use it via an alternate type that permits 'null' or an object); but we'll create that usage when we need it. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1461879932-9020-15-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
42 lines
1.2 KiB
C
42 lines
1.2 KiB
C
/*
|
|
* Options Visitor
|
|
*
|
|
* Copyright Red Hat, Inc. 2012
|
|
*
|
|
* Author: Laszlo Ersek <lersek@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
|
|
* See the COPYING.LIB file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef OPTS_VISITOR_H
|
|
#define OPTS_VISITOR_H
|
|
|
|
#include "qapi/visitor.h"
|
|
#include "qemu/option.h"
|
|
|
|
/* Inclusive upper bound on the size of any flattened range. This is a safety
|
|
* (= anti-annoyance) measure; wrong ranges should not cause long startup
|
|
* delays nor exhaust virtual memory.
|
|
*/
|
|
#define OPTS_VISITOR_RANGE_MAX 65536
|
|
|
|
typedef struct OptsVisitor OptsVisitor;
|
|
|
|
/* Contrarily to qemu-option.c::parse_option_number(), OptsVisitor's "int"
|
|
* parser relies on strtoll() instead of strtoull(). Consequences:
|
|
* - string representations of negative numbers yield negative values,
|
|
* - values below INT64_MIN or LLONG_MIN are rejected,
|
|
* - values above INT64_MAX or LLONG_MAX are rejected.
|
|
*
|
|
* The Opts input visitor does not implement support for visiting QAPI
|
|
* alternates, numbers (other than integers), null, or arbitrary
|
|
* QTypes.
|
|
*/
|
|
OptsVisitor *opts_visitor_new(const QemuOpts *opts);
|
|
void opts_visitor_cleanup(OptsVisitor *nv);
|
|
Visitor *opts_get_visitor(OptsVisitor *nv);
|
|
|
|
#endif
|