42eb58179b
Too large L2 table sizes cause unbounded allocations. Images actually created by qemu-img only have 512 byte or 4k L2 tables. To keep things consistent with cluster sizes, allow ranges between 512 bytes and 64k (in fact, down to 1 entry = 8 bytes is technically working, but L2 table sizes smaller than a cluster don't make a lot of sense). This also means that the number of bytes on the virtual disk that are described by the same L2 table is limited to at most 8k * 64k or 2^29, preventively avoiding any integer overflows. Cc: qemu-stable@nongnu.org Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Benoit Canet <benoit@irqsave.net>
25 lines
1.1 KiB
Plaintext
25 lines
1.1 KiB
Plaintext
QA output created by 092
|
|
|
|
== Invalid cluster size ==
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
qemu-io: can't open device TEST_DIR/t.qcow: Cluster size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: Cluster size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: Cluster size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: Cluster size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
|
|
== Invalid L2 table size ==
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
|
|
qemu-io: can't open device TEST_DIR/t.qcow: L2 table size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: L2 table size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: L2 table size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
qemu-io: can't open device TEST_DIR/t.qcow: L2 table size must be between 512 and 64k
|
|
no file open, try 'help open'
|
|
*** done
|