qemu-img info should only be used directly if the format-specific information or the name of the format is relevant (some tests explicitly test format-specific information; test 082 uses qcow2-specific settings to test the qemu-img interface); otherwise, tests should always use _img_info instead. Test 082 was touched only partially. It does test the qemu-img interface; however, its invocations of qemu-img info are not real tests but rather verifications, so if format-specific information is not important for the test, there is no reason not to use _img_info. In contrast to directly invoking qemu-img info, "qcow2" is replaced by "IMGFMT"; but as "qcow2" is only mentioned once in test 082 (in _supported_fmt), I consider this an improvement. Signed-off-by: Max Reitz <mreitz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 1412105489-7681-2-git-send-email-mreitz@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
24 lines
862 B
Plaintext
24 lines
862 B
Plaintext
QA output created by 095
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=5242880
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=104857600 backing_file='TEST_DIR/t.IMGFMT.base'
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=104857600 backing_file='TEST_DIR/t.IMGFMT.snp1'
|
|
|
|
=== Base image info before commit and resize ===
|
|
image: TEST_DIR/t.IMGFMT.base
|
|
file format: IMGFMT
|
|
virtual size: 5.0M (5242880 bytes)
|
|
cluster_size: 65536
|
|
|
|
=== Running QEMU Live Commit Test ===
|
|
|
|
{"return": {}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "test", "len": 104857600, "offset": 104857600, "speed": 0, "type": "commit"}}
|
|
|
|
=== Base image info after commit and resize ===
|
|
image: TEST_DIR/t.IMGFMT.base
|
|
file format: IMGFMT
|
|
virtual size: 100M (104857600 bytes)
|
|
cluster_size: 65536
|
|
*** done
|