Anywhere we create a list of just one item or by prepending items (typically because order doesn't matter), we can use QAPI_LIST_PREPEND(). But places where we must keep the list in order by appending remain open-coded until later patches. Note that as a side effect, this also performs a cleanup of two minor issues in qga/commands-posix.c: the old code was performing new = g_malloc0(sizeof(*ret)); which 1) is confusing because you have to verify whether 'new' and 'ret' are variables with the same type, and 2) would conflict with C++ compilation (not an actual problem for this file, but makes copy-and-paste harder). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20201113011340.463563-5-eblake@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Acked-by: Stefan Hajnoczi <stefanha@redhat.com> [Straightforward conflicts due to commit |
||
---|---|---|
.. | ||
qmp-norocker.c | ||
rocker.c | ||
rocker.h | ||
rocker_desc.c | ||
rocker_desc.h | ||
rocker_fp.c | ||
rocker_fp.h | ||
rocker_hw.h | ||
rocker_of_dpa.c | ||
rocker_of_dpa.h | ||
rocker_tlv.h | ||
rocker_world.c | ||
rocker_world.h |