The DEVICE() macro is defined as: #define DEVICE(obj) OBJECT_CHECK(DeviceState, (obj), TYPE_DEVICE) which expands to: ((DeviceState *)object_dynamic_cast_assert((Object *)(obj), (name), __FILE__, __LINE__, __func__)) This assertion can only fail when @obj points to something other than its stated type, i.e. when we're in undefined behavior country. Remove the unnecessary DEVICE() casts when we already know the pointer is of DeviceState type. Patch created mechanically using spatch with this script: @@ typedef DeviceState; DeviceState *s; @@ - DEVICE(s) + s Acked-by: David Gibson <david@gibson.dropbear.id.au> Acked-by: Paul Durrant <paul@xen.org> Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Acked-by: John Snow <jsnow@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-Id: <20200512070020.22782-4-f4bug@amsat.org>
115 lines
3.7 KiB
C
115 lines
3.7 KiB
C
/*
|
|
* QEMU ISA VGA Emulator.
|
|
*
|
|
* see docs/specs/standard-vga.txt for virtual hardware specs.
|
|
*
|
|
* Copyright (c) 2003 Fabrice Bellard
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/isa/isa.h"
|
|
#include "vga_int.h"
|
|
#include "ui/pixel_ops.h"
|
|
#include "qemu/module.h"
|
|
#include "qemu/timer.h"
|
|
#include "hw/loader.h"
|
|
#include "hw/qdev-properties.h"
|
|
|
|
#define TYPE_ISA_VGA "isa-vga"
|
|
#define ISA_VGA(obj) OBJECT_CHECK(ISAVGAState, (obj), TYPE_ISA_VGA)
|
|
|
|
typedef struct ISAVGAState {
|
|
ISADevice parent_obj;
|
|
|
|
struct VGACommonState state;
|
|
PortioList portio_vga;
|
|
PortioList portio_vbe;
|
|
} ISAVGAState;
|
|
|
|
static void vga_isa_reset(DeviceState *dev)
|
|
{
|
|
ISAVGAState *d = ISA_VGA(dev);
|
|
VGACommonState *s = &d->state;
|
|
|
|
vga_common_reset(s);
|
|
}
|
|
|
|
static void vga_isa_realizefn(DeviceState *dev, Error **errp)
|
|
{
|
|
ISADevice *isadev = ISA_DEVICE(dev);
|
|
ISAVGAState *d = ISA_VGA(dev);
|
|
VGACommonState *s = &d->state;
|
|
MemoryRegion *vga_io_memory;
|
|
const MemoryRegionPortio *vga_ports, *vbe_ports;
|
|
|
|
s->global_vmstate = true;
|
|
vga_common_init(s, OBJECT(dev));
|
|
s->legacy_address_space = isa_address_space(isadev);
|
|
vga_io_memory = vga_init_io(s, OBJECT(dev), &vga_ports, &vbe_ports);
|
|
isa_register_portio_list(isadev, &d->portio_vga,
|
|
0x3b0, vga_ports, s, "vga");
|
|
if (vbe_ports) {
|
|
isa_register_portio_list(isadev, &d->portio_vbe,
|
|
0x1ce, vbe_ports, s, "vbe");
|
|
}
|
|
memory_region_add_subregion_overlap(isa_address_space(isadev),
|
|
0x000a0000,
|
|
vga_io_memory, 1);
|
|
memory_region_set_coalescing(vga_io_memory);
|
|
s->con = graphic_console_init(dev, 0, s->hw_ops, s);
|
|
|
|
memory_region_add_subregion(isa_address_space(isadev),
|
|
VBE_DISPI_LFB_PHYSICAL_ADDRESS,
|
|
&s->vram);
|
|
/* ROM BIOS */
|
|
rom_add_vga(VGABIOS_FILENAME);
|
|
}
|
|
|
|
static Property vga_isa_properties[] = {
|
|
DEFINE_PROP_UINT32("vgamem_mb", ISAVGAState, state.vram_size_mb, 8),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void vga_isa_class_initfn(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->realize = vga_isa_realizefn;
|
|
dc->reset = vga_isa_reset;
|
|
dc->vmsd = &vmstate_vga_common;
|
|
device_class_set_props(dc, vga_isa_properties);
|
|
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
|
|
}
|
|
|
|
static const TypeInfo vga_isa_info = {
|
|
.name = TYPE_ISA_VGA,
|
|
.parent = TYPE_ISA_DEVICE,
|
|
.instance_size = sizeof(ISAVGAState),
|
|
.class_init = vga_isa_class_initfn,
|
|
};
|
|
|
|
static void vga_isa_register_types(void)
|
|
{
|
|
type_register_static(&vga_isa_info);
|
|
}
|
|
|
|
type_init(vga_isa_register_types)
|