7f16c76e83
ssi_auto_connect_slaves(parent, cs_line, bus) iterates over @parent's
QOM children @dev of type TYPE_SSI_SLAVE. It puts these on @bus, and
sets cs_line[] to qdev_get_gpio_in_named(dev, SSI_GPIO_CS, 0).
Suspicious: there is no protection against overrunning cs_line[].
Turns out it's safe because ssi_auto_connect_slaves() never finds any
such children. Its called by realize methods of some (but not all)
devices providing an SSI bus, and gets passed the device.
SSI slave devices are always created with ssi_create_slave_no_init(),
optionally via ssi_create_slave(). This adds them to their SSI bus.
It doesn't set their QOM parent.
ssi_create_slave_no_init() is always immediately followed by
qdev_init_nofail(), with no QOM parent assigned, so
device_set_realized() puts the device into the /machine/unattached/
orphanage. None become QOM children of a device providing an SSI bus.
ssi_auto_connect_slaves() was added in commit b4ae3cfa57 "ssi: Add
slave autoconnect helper". I can't see which slaves it was supposed
to connect back then.
Cc: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-23-armbru@redhat.com>
145 lines
3.5 KiB
C
145 lines
3.5 KiB
C
/*
|
|
* QEMU Synchronous Serial Interface support
|
|
*
|
|
* Copyright (c) 2009 CodeSourcery.
|
|
* Copyright (c) 2012 Peter A.G. Crosthwaite (peter.crosthwaite@petalogix.com)
|
|
* Copyright (c) 2012 PetaLogix Pty Ltd.
|
|
* Written by Paul Brook
|
|
*
|
|
* This code is licensed under the GNU GPL v2.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/ssi/ssi.h"
|
|
#include "migration/vmstate.h"
|
|
#include "qemu/module.h"
|
|
|
|
struct SSIBus {
|
|
BusState parent_obj;
|
|
};
|
|
|
|
#define TYPE_SSI_BUS "SSI"
|
|
#define SSI_BUS(obj) OBJECT_CHECK(SSIBus, (obj), TYPE_SSI_BUS)
|
|
|
|
static const TypeInfo ssi_bus_info = {
|
|
.name = TYPE_SSI_BUS,
|
|
.parent = TYPE_BUS,
|
|
.instance_size = sizeof(SSIBus),
|
|
};
|
|
|
|
static void ssi_cs_default(void *opaque, int n, int level)
|
|
{
|
|
SSISlave *s = SSI_SLAVE(opaque);
|
|
bool cs = !!level;
|
|
assert(n == 0);
|
|
if (s->cs != cs) {
|
|
SSISlaveClass *ssc = SSI_SLAVE_GET_CLASS(s);
|
|
if (ssc->set_cs) {
|
|
ssc->set_cs(s, cs);
|
|
}
|
|
}
|
|
s->cs = cs;
|
|
}
|
|
|
|
static uint32_t ssi_transfer_raw_default(SSISlave *dev, uint32_t val)
|
|
{
|
|
SSISlaveClass *ssc = SSI_SLAVE_GET_CLASS(dev);
|
|
|
|
if ((dev->cs && ssc->cs_polarity == SSI_CS_HIGH) ||
|
|
(!dev->cs && ssc->cs_polarity == SSI_CS_LOW) ||
|
|
ssc->cs_polarity == SSI_CS_NONE) {
|
|
return ssc->transfer(dev, val);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void ssi_slave_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
SSISlave *s = SSI_SLAVE(dev);
|
|
SSISlaveClass *ssc = SSI_SLAVE_GET_CLASS(s);
|
|
|
|
if (ssc->transfer_raw == ssi_transfer_raw_default &&
|
|
ssc->cs_polarity != SSI_CS_NONE) {
|
|
qdev_init_gpio_in_named(dev, ssi_cs_default, SSI_GPIO_CS, 1);
|
|
}
|
|
|
|
ssc->realize(s, errp);
|
|
}
|
|
|
|
static void ssi_slave_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
SSISlaveClass *ssc = SSI_SLAVE_CLASS(klass);
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->realize = ssi_slave_realize;
|
|
dc->bus_type = TYPE_SSI_BUS;
|
|
if (!ssc->transfer_raw) {
|
|
ssc->transfer_raw = ssi_transfer_raw_default;
|
|
}
|
|
}
|
|
|
|
static const TypeInfo ssi_slave_info = {
|
|
.name = TYPE_SSI_SLAVE,
|
|
.parent = TYPE_DEVICE,
|
|
.class_init = ssi_slave_class_init,
|
|
.class_size = sizeof(SSISlaveClass),
|
|
.abstract = true,
|
|
};
|
|
|
|
DeviceState *ssi_create_slave_no_init(SSIBus *bus, const char *name)
|
|
{
|
|
return qdev_create(BUS(bus), name);
|
|
}
|
|
|
|
DeviceState *ssi_create_slave(SSIBus *bus, const char *name)
|
|
{
|
|
DeviceState *dev = ssi_create_slave_no_init(bus, name);
|
|
|
|
qdev_init_nofail(dev);
|
|
return dev;
|
|
}
|
|
|
|
SSIBus *ssi_create_bus(DeviceState *parent, const char *name)
|
|
{
|
|
BusState *bus;
|
|
bus = qbus_create(TYPE_SSI_BUS, parent, name);
|
|
return SSI_BUS(bus);
|
|
}
|
|
|
|
uint32_t ssi_transfer(SSIBus *bus, uint32_t val)
|
|
{
|
|
BusState *b = BUS(bus);
|
|
BusChild *kid;
|
|
SSISlaveClass *ssc;
|
|
uint32_t r = 0;
|
|
|
|
QTAILQ_FOREACH(kid, &b->children, sibling) {
|
|
SSISlave *slave = SSI_SLAVE(kid->child);
|
|
ssc = SSI_SLAVE_GET_CLASS(slave);
|
|
r |= ssc->transfer_raw(slave, val);
|
|
}
|
|
|
|
return r;
|
|
}
|
|
|
|
const VMStateDescription vmstate_ssi_slave = {
|
|
.name = "SSISlave",
|
|
.version_id = 1,
|
|
.minimum_version_id = 1,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_BOOL(cs, SSISlave),
|
|
VMSTATE_END_OF_LIST()
|
|
}
|
|
};
|
|
|
|
static void ssi_slave_register_types(void)
|
|
{
|
|
type_register_static(&ssi_bus_info);
|
|
type_register_static(&ssi_slave_info);
|
|
}
|
|
|
|
type_init(ssi_slave_register_types)
|