qemu-patch-raspberry4/hw/isa
Markus Armbruster 96927c744f isa: Convert uses of isa_create() with Coccinelle
Replace

    dev = isa_create(bus, type_name);
    ...
    qdev_init_nofail(dev);

by

    dev = isa_new(type_name);
    ...
    isa_realize_and_unref(dev, bus, &error_fatal);

Recent commit "qdev: New qdev_new(), qdev_realize(), etc." explains
why.

Coccinelle script:

    @@
    expression dev, bus, expr;
    expression list args;
    expression d;
    @@
    -    dev = isa_create(bus, args);
    +    dev = isa_new(args);
    (
         d = &dev->qdev;
    |
         d = DEVICE(dev);
    )
         ... when != dev = expr
    -    qdev_init_nofail(d);
    +    isa_realize_and_unref(dev, bus, &error_fatal);

    @@
    expression dev, bus, expr;
    expression list args;
    @@
    -    dev = isa_create(bus, args);
    +    dev = isa_new(args);
         ... when != dev = expr
    -    qdev_init_nofail(DEVICE(dev));
    +    isa_realize_and_unref(dev, bus, &error_fatal);

    @@
    expression dev, bus, expr;
    expression list args;
    @@
    -    dev = DEVICE(isa_create(bus, args));
    +    ISADevice *isa_dev; // TODO move
    +    isa_dev = isa_new(args);
    +    dev = DEVICE(isa_dev);
         ... when != dev = expr
    -    qdev_init_nofail(dev);
    +    isa_realize_and_unref(isa_dev, bus, &error_fatal);

Missing #include "qapi/error.h" added manually, whitespace changes
minimized manually.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200610053247.1583243-20-armbru@redhat.com>
2020-06-15 22:05:28 +02:00
..
apm.c hw/isa/apm: Convert debug printf()s to trace events 2020-06-09 19:05:20 +02:00
i82378.c hw/isa/i82378: Remove dead assignment 2020-05-04 14:43:24 +02:00
isa-bus.c isa: Convert uses of isa_create() with Coccinelle 2020-06-15 22:05:28 +02:00
isa-superio.c isa: Convert uses of isa_create() with Coccinelle 2020-06-15 22:05:28 +02:00
Kconfig hw/input: Do not enable CONFIG_PCKBD by default 2020-02-04 09:01:31 +01:00
lpc_ich9.c Drop more @errp parameters after previous commit 2020-05-15 07:08:14 +02:00
Makefile.objs hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c 2019-11-05 23:33:12 +01:00
pc87312.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
piix3.c accel: Move Xen accelerator code under accel/xen/ 2020-06-10 12:09:56 -04:00
piix4.c qdev: Convert uses of qdev_set_parent_bus() with Coccinelle 2020-06-15 22:05:08 +02:00
smc37c669-superio.c hw/isa/superio: Correct the license text 2020-04-01 19:00:16 +02:00
trace-events hw/isa/apm: Convert debug printf()s to trace events 2020-06-09 19:05:20 +02:00
vt82c686.c pci: Convert uses of pci_create() etc. with Coccinelle 2020-06-15 22:05:28 +02:00