The current code assumes that only the CPU core object holds a reference on each individual CPU object, and happily frees their allocated memory when the core is unrealized. This is dangerous as some other code can legitimely keep a pointer to a CPU if it calls object_ref(), but it would end up with a dangling pointer. Let's allocate all CPUs with object_new() and let QOM free them when their reference count reaches zero. This greatly simplify the code as we don't have to fiddle with the instance size anymore. Signed-off-by: Greg Kurz <groug@kaod.org> Acked-by: Igor Mammedov <imammedo@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
42 lines
1.1 KiB
C
42 lines
1.1 KiB
C
/*
|
|
* sPAPR CPU core device.
|
|
*
|
|
* Copyright (C) 2016 Bharata B Rao <bharata@linux.vnet.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
#ifndef HW_SPAPR_CPU_CORE_H
|
|
#define HW_SPAPR_CPU_CORE_H
|
|
|
|
#include "hw/qdev.h"
|
|
#include "hw/cpu/core.h"
|
|
#include "target/ppc/cpu-qom.h"
|
|
|
|
#define TYPE_SPAPR_CPU_CORE "spapr-cpu-core"
|
|
#define SPAPR_CPU_CORE(obj) \
|
|
OBJECT_CHECK(sPAPRCPUCore, (obj), TYPE_SPAPR_CPU_CORE)
|
|
#define SPAPR_CPU_CORE_CLASS(klass) \
|
|
OBJECT_CLASS_CHECK(sPAPRCPUCoreClass, (klass), TYPE_SPAPR_CPU_CORE)
|
|
#define SPAPR_CPU_CORE_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(sPAPRCPUCoreClass, (obj), TYPE_SPAPR_CPU_CORE)
|
|
|
|
#define SPAPR_CPU_CORE_TYPE_NAME(model) model "-" TYPE_SPAPR_CPU_CORE
|
|
|
|
typedef struct sPAPRCPUCore {
|
|
/*< private >*/
|
|
CPUCore parent_obj;
|
|
|
|
/*< public >*/
|
|
PowerPCCPU **threads;
|
|
int node_id;
|
|
} sPAPRCPUCore;
|
|
|
|
typedef struct sPAPRCPUCoreClass {
|
|
DeviceClass parent_class;
|
|
const char *cpu_type;
|
|
} sPAPRCPUCoreClass;
|
|
|
|
const char *spapr_get_cpu_core_type(const char *cpu_type);
|
|
#endif
|