e4603fe139
In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated, while obviously correct behaviour would be to leave the on-disk backing file path/format unchanged. Fix this and add a test case for it. Reported-by: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Kevin Wolf <kwolf@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 1428411796-2852-1-git-send-email-kwolf@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
96 lines
2.8 KiB
Bash
Executable file
96 lines
2.8 KiB
Bash
Executable file
#!/bin/bash
|
|
#
|
|
# Test that temporary backing file overrides (on the command line or in
|
|
# blockdev-add) don't replace the original path stored in the image during
|
|
# header updates.
|
|
#
|
|
# Copyright (C) 2015 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=kwolf@redhat.com
|
|
|
|
seq="$(basename $0)"
|
|
echo "QA output created by $seq"
|
|
|
|
here="$PWD"
|
|
tmp=/tmp/$$
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_test_img
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
. ./common.qemu
|
|
|
|
_supported_fmt qcow2
|
|
_supported_proto generic
|
|
_supported_os Linux
|
|
|
|
qemu_comm_method="monitor"
|
|
|
|
|
|
TEST_IMG="$TEST_IMG.orig" _make_test_img 64M
|
|
TEST_IMG="$TEST_IMG.base" _make_test_img 64M
|
|
_make_test_img 64M
|
|
_img_info | _filter_img_info
|
|
|
|
echo
|
|
echo "=== HMP commit ==="
|
|
echo
|
|
# bdrv_make_empty() involves a header update for qcow2
|
|
|
|
# Test that a backing file isn't written
|
|
_launch_qemu -drive file="$TEST_IMG",backing.file.filename="$TEST_IMG.base"
|
|
_send_qemu_cmd $QEMU_HANDLE "commit ide0-hd0" "(qemu)"
|
|
_send_qemu_cmd $QEMU_HANDLE '' '(qemu)'
|
|
_cleanup_qemu
|
|
_img_info | _filter_img_info
|
|
|
|
# Make sure that if there was a backing file that was just overridden on the
|
|
# command line, that backing file is retained, with the right format
|
|
_make_test_img -F raw -b "$TEST_IMG.orig" 64M
|
|
_launch_qemu -drive file="$TEST_IMG",backing.file.filename="$TEST_IMG.base",backing.driver=$IMGFMT
|
|
_send_qemu_cmd $QEMU_HANDLE "commit ide0-hd0" "(qemu)"
|
|
_send_qemu_cmd $QEMU_HANDLE '' '(qemu)'
|
|
_cleanup_qemu
|
|
_img_info | _filter_img_info
|
|
|
|
echo
|
|
echo "=== Marking image dirty (lazy refcounts) ==="
|
|
echo
|
|
|
|
# Test that a backing file isn't written
|
|
_make_test_img 64M
|
|
$QEMU_IO -c "open -o backing.file.filename=$TEST_IMG.base,lazy-refcounts=on $TEST_IMG" -c "write 0 4k" | _filter_qemu_io
|
|
_img_info | _filter_img_info
|
|
|
|
# Make sure that if there was a backing file that was just overridden on the
|
|
# command line, that backing file is retained, with the right format
|
|
_make_test_img -F raw -b "$TEST_IMG.orig" 64M
|
|
$QEMU_IO -c "open -o backing.file.filename=$TEST_IMG.base,backing.driver=$IMGFMT,lazy-refcounts=on $TEST_IMG" -c "write 0 4k" | _filter_qemu_io
|
|
_img_info | _filter_img_info
|
|
|
|
# success, all done
|
|
echo '*** done'
|
|
rm -f $seq.full
|
|
status=0
|