The only way object_property_add() can fail is when a property with the same name already exists. Since our property names are all hardcoded, failure is a programming error, and the appropriate way to handle it is passing &error_abort. Same for its variants, except for object_property_add_child(), which additionally fails when the child already has a parent. Parentage is also under program control, so this is a programming error, too. We have a bit over 500 callers. Almost half of them pass &error_abort, slightly fewer ignore errors, one test case handles errors, and the remaining few callers pass them to their own callers. The previous few commits demonstrated once again that ignoring programming errors is a bad idea. Of the few ones that pass on errors, several violate the Error API. The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. ich9_pm_add_properties(), sparc32_ledma_realize(), sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize() are wrong that way. When the one appropriate choice of argument is &error_abort, letting users pick the argument is a bad idea. Drop parameter @errp and assert the preconditions instead. There's one exception to "duplicate property name is a programming error": the way object_property_add() implements the magic (and undocumented) "automatic arrayification". Don't drop @errp there. Instead, rename object_property_add() to object_property_try_add(), and add the obvious wrapper object_property_add(). Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20200505152926.18877-15-armbru@redhat.com> [Two semantic rebase conflicts resolved]
420 lines
14 KiB
C
420 lines
14 KiB
C
/*
|
|
* QEMU i440FX PCI Bridge Emulation
|
|
*
|
|
* Copyright (c) 2006 Fabrice Bellard
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/range.h"
|
|
#include "hw/i386/pc.h"
|
|
#include "hw/pci/pci.h"
|
|
#include "hw/pci/pci_host.h"
|
|
#include "hw/pci-host/i440fx.h"
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/sysbus.h"
|
|
#include "qapi/error.h"
|
|
#include "migration/vmstate.h"
|
|
#include "qapi/visitor.h"
|
|
#include "qemu/error-report.h"
|
|
|
|
/*
|
|
* I440FX chipset data sheet.
|
|
* https://wiki.qemu.org/File:29054901.pdf
|
|
*/
|
|
|
|
#define I440FX_PCI_HOST_BRIDGE(obj) \
|
|
OBJECT_CHECK(I440FXState, (obj), TYPE_I440FX_PCI_HOST_BRIDGE)
|
|
|
|
typedef struct I440FXState {
|
|
PCIHostState parent_obj;
|
|
Range pci_hole;
|
|
uint64_t pci_hole64_size;
|
|
bool pci_hole64_fix;
|
|
uint32_t short_root_bus;
|
|
} I440FXState;
|
|
|
|
#define I440FX_PAM 0x59
|
|
#define I440FX_PAM_SIZE 7
|
|
#define I440FX_SMRAM 0x72
|
|
|
|
/* Keep it 2G to comply with older win32 guests */
|
|
#define I440FX_PCI_HOST_HOLE64_SIZE_DEFAULT (1ULL << 31)
|
|
|
|
/* Older coreboot versions (4.0 and older) read a config register that doesn't
|
|
* exist in real hardware, to get the RAM size from QEMU.
|
|
*/
|
|
#define I440FX_COREBOOT_RAM_SIZE 0x57
|
|
|
|
static void i440fx_update_memory_mappings(PCII440FXState *d)
|
|
{
|
|
int i;
|
|
PCIDevice *pd = PCI_DEVICE(d);
|
|
|
|
memory_region_transaction_begin();
|
|
for (i = 0; i < ARRAY_SIZE(d->pam_regions); i++) {
|
|
pam_update(&d->pam_regions[i], i,
|
|
pd->config[I440FX_PAM + DIV_ROUND_UP(i, 2)]);
|
|
}
|
|
memory_region_set_enabled(&d->smram_region,
|
|
!(pd->config[I440FX_SMRAM] & SMRAM_D_OPEN));
|
|
memory_region_set_enabled(&d->smram,
|
|
pd->config[I440FX_SMRAM] & SMRAM_G_SMRAME);
|
|
memory_region_transaction_commit();
|
|
}
|
|
|
|
|
|
static void i440fx_write_config(PCIDevice *dev,
|
|
uint32_t address, uint32_t val, int len)
|
|
{
|
|
PCII440FXState *d = I440FX_PCI_DEVICE(dev);
|
|
|
|
/* XXX: implement SMRAM.D_LOCK */
|
|
pci_default_write_config(dev, address, val, len);
|
|
if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) ||
|
|
range_covers_byte(address, len, I440FX_SMRAM)) {
|
|
i440fx_update_memory_mappings(d);
|
|
}
|
|
}
|
|
|
|
static int i440fx_post_load(void *opaque, int version_id)
|
|
{
|
|
PCII440FXState *d = opaque;
|
|
|
|
i440fx_update_memory_mappings(d);
|
|
return 0;
|
|
}
|
|
|
|
static const VMStateDescription vmstate_i440fx = {
|
|
.name = "I440FX",
|
|
.version_id = 3,
|
|
.minimum_version_id = 3,
|
|
.post_load = i440fx_post_load,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_PCI_DEVICE(parent_obj, PCII440FXState),
|
|
/* Used to be smm_enabled, which was basically always zero because
|
|
* SeaBIOS hardly uses SMM. SMRAM is now handled by CPU code.
|
|
*/
|
|
VMSTATE_UNUSED(1),
|
|
VMSTATE_END_OF_LIST()
|
|
}
|
|
};
|
|
|
|
static void i440fx_pcihost_get_pci_hole_start(Object *obj, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
I440FXState *s = I440FX_PCI_HOST_BRIDGE(obj);
|
|
uint64_t val64;
|
|
uint32_t value;
|
|
|
|
val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole);
|
|
value = val64;
|
|
assert(value == val64);
|
|
visit_type_uint32(v, name, &value, errp);
|
|
}
|
|
|
|
static void i440fx_pcihost_get_pci_hole_end(Object *obj, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
I440FXState *s = I440FX_PCI_HOST_BRIDGE(obj);
|
|
uint64_t val64;
|
|
uint32_t value;
|
|
|
|
val64 = range_is_empty(&s->pci_hole) ? 0 : range_upb(&s->pci_hole) + 1;
|
|
value = val64;
|
|
assert(value == val64);
|
|
visit_type_uint32(v, name, &value, errp);
|
|
}
|
|
|
|
/*
|
|
* The 64bit PCI hole start is set by the Guest firmware
|
|
* as the address of the first 64bit PCI MEM resource.
|
|
* If no PCI device has resources on the 64bit area,
|
|
* the 64bit PCI hole will start after "over 4G RAM" and the
|
|
* reserved space for memory hotplug if any.
|
|
*/
|
|
static uint64_t i440fx_pcihost_get_pci_hole64_start_value(Object *obj)
|
|
{
|
|
PCIHostState *h = PCI_HOST_BRIDGE(obj);
|
|
I440FXState *s = I440FX_PCI_HOST_BRIDGE(obj);
|
|
Range w64;
|
|
uint64_t value;
|
|
|
|
pci_bus_get_w64_range(h->bus, &w64);
|
|
value = range_is_empty(&w64) ? 0 : range_lob(&w64);
|
|
if (!value && s->pci_hole64_fix) {
|
|
value = pc_pci_hole64_start();
|
|
}
|
|
return value;
|
|
}
|
|
|
|
static void i440fx_pcihost_get_pci_hole64_start(Object *obj, Visitor *v,
|
|
const char *name,
|
|
void *opaque, Error **errp)
|
|
{
|
|
uint64_t hole64_start = i440fx_pcihost_get_pci_hole64_start_value(obj);
|
|
|
|
visit_type_uint64(v, name, &hole64_start, errp);
|
|
}
|
|
|
|
/*
|
|
* The 64bit PCI hole end is set by the Guest firmware
|
|
* as the address of the last 64bit PCI MEM resource.
|
|
* Then it is expanded to the PCI_HOST_PROP_PCI_HOLE64_SIZE
|
|
* that can be configured by the user.
|
|
*/
|
|
static void i440fx_pcihost_get_pci_hole64_end(Object *obj, Visitor *v,
|
|
const char *name, void *opaque,
|
|
Error **errp)
|
|
{
|
|
PCIHostState *h = PCI_HOST_BRIDGE(obj);
|
|
I440FXState *s = I440FX_PCI_HOST_BRIDGE(obj);
|
|
uint64_t hole64_start = i440fx_pcihost_get_pci_hole64_start_value(obj);
|
|
Range w64;
|
|
uint64_t value, hole64_end;
|
|
|
|
pci_bus_get_w64_range(h->bus, &w64);
|
|
value = range_is_empty(&w64) ? 0 : range_upb(&w64) + 1;
|
|
hole64_end = ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30);
|
|
if (s->pci_hole64_fix && value < hole64_end) {
|
|
value = hole64_end;
|
|
}
|
|
visit_type_uint64(v, name, &value, errp);
|
|
}
|
|
|
|
static void i440fx_pcihost_initfn(Object *obj)
|
|
{
|
|
PCIHostState *s = PCI_HOST_BRIDGE(obj);
|
|
|
|
memory_region_init_io(&s->conf_mem, obj, &pci_host_conf_le_ops, s,
|
|
"pci-conf-idx", 4);
|
|
memory_region_init_io(&s->data_mem, obj, &pci_host_data_le_ops, s,
|
|
"pci-conf-data", 4);
|
|
|
|
object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_START, "uint32",
|
|
i440fx_pcihost_get_pci_hole_start,
|
|
NULL, NULL, NULL);
|
|
|
|
object_property_add(obj, PCI_HOST_PROP_PCI_HOLE_END, "uint32",
|
|
i440fx_pcihost_get_pci_hole_end,
|
|
NULL, NULL, NULL);
|
|
|
|
object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_START, "uint64",
|
|
i440fx_pcihost_get_pci_hole64_start,
|
|
NULL, NULL, NULL);
|
|
|
|
object_property_add(obj, PCI_HOST_PROP_PCI_HOLE64_END, "uint64",
|
|
i440fx_pcihost_get_pci_hole64_end,
|
|
NULL, NULL, NULL);
|
|
}
|
|
|
|
static void i440fx_pcihost_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
PCIHostState *s = PCI_HOST_BRIDGE(dev);
|
|
SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
|
|
|
|
sysbus_add_io(sbd, 0xcf8, &s->conf_mem);
|
|
sysbus_init_ioports(sbd, 0xcf8, 4);
|
|
|
|
sysbus_add_io(sbd, 0xcfc, &s->data_mem);
|
|
sysbus_init_ioports(sbd, 0xcfc, 4);
|
|
|
|
/* register i440fx 0xcf8 port as coalesced pio */
|
|
memory_region_set_flush_coalesced(&s->data_mem);
|
|
memory_region_add_coalescing(&s->conf_mem, 0, 4);
|
|
}
|
|
|
|
static void i440fx_realize(PCIDevice *dev, Error **errp)
|
|
{
|
|
dev->config[I440FX_SMRAM] = 0x02;
|
|
|
|
if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) {
|
|
warn_report("i440fx doesn't support emulated iommu");
|
|
}
|
|
}
|
|
|
|
PCIBus *i440fx_init(const char *host_type, const char *pci_type,
|
|
PCII440FXState **pi440fx_state,
|
|
MemoryRegion *address_space_mem,
|
|
MemoryRegion *address_space_io,
|
|
ram_addr_t ram_size,
|
|
ram_addr_t below_4g_mem_size,
|
|
ram_addr_t above_4g_mem_size,
|
|
MemoryRegion *pci_address_space,
|
|
MemoryRegion *ram_memory)
|
|
{
|
|
DeviceState *dev;
|
|
PCIBus *b;
|
|
PCIDevice *d;
|
|
PCIHostState *s;
|
|
PCII440FXState *f;
|
|
unsigned i;
|
|
I440FXState *i440fx;
|
|
|
|
dev = qdev_create(NULL, host_type);
|
|
s = PCI_HOST_BRIDGE(dev);
|
|
b = pci_root_bus_new(dev, NULL, pci_address_space,
|
|
address_space_io, 0, TYPE_PCI_BUS);
|
|
s->bus = b;
|
|
object_property_add_child(qdev_get_machine(), "i440fx", OBJECT(dev));
|
|
qdev_init_nofail(dev);
|
|
|
|
d = pci_create_simple(b, 0, pci_type);
|
|
*pi440fx_state = I440FX_PCI_DEVICE(d);
|
|
f = *pi440fx_state;
|
|
f->system_memory = address_space_mem;
|
|
f->pci_address_space = pci_address_space;
|
|
f->ram_memory = ram_memory;
|
|
|
|
i440fx = I440FX_PCI_HOST_BRIDGE(dev);
|
|
range_set_bounds(&i440fx->pci_hole, below_4g_mem_size,
|
|
IO_APIC_DEFAULT_ADDRESS - 1);
|
|
|
|
/* setup pci memory mapping */
|
|
pc_pci_as_mapping_init(OBJECT(f), f->system_memory,
|
|
f->pci_address_space);
|
|
|
|
/* if *disabled* show SMRAM to all CPUs */
|
|
memory_region_init_alias(&f->smram_region, OBJECT(d), "smram-region",
|
|
f->pci_address_space, 0xa0000, 0x20000);
|
|
memory_region_add_subregion_overlap(f->system_memory, 0xa0000,
|
|
&f->smram_region, 1);
|
|
memory_region_set_enabled(&f->smram_region, true);
|
|
|
|
/* smram, as seen by SMM CPUs */
|
|
memory_region_init(&f->smram, OBJECT(d), "smram", 1ull << 32);
|
|
memory_region_set_enabled(&f->smram, true);
|
|
memory_region_init_alias(&f->low_smram, OBJECT(d), "smram-low",
|
|
f->ram_memory, 0xa0000, 0x20000);
|
|
memory_region_set_enabled(&f->low_smram, true);
|
|
memory_region_add_subregion(&f->smram, 0xa0000, &f->low_smram);
|
|
object_property_add_const_link(qdev_get_machine(), "smram",
|
|
OBJECT(&f->smram));
|
|
|
|
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
|
|
&f->pam_regions[0], PAM_BIOS_BASE, PAM_BIOS_SIZE);
|
|
for (i = 0; i < ARRAY_SIZE(f->pam_regions) - 1; ++i) {
|
|
init_pam(dev, f->ram_memory, f->system_memory, f->pci_address_space,
|
|
&f->pam_regions[i+1], PAM_EXPAN_BASE + i * PAM_EXPAN_SIZE,
|
|
PAM_EXPAN_SIZE);
|
|
}
|
|
|
|
ram_size = ram_size / 8 / 1024 / 1024;
|
|
if (ram_size > 255) {
|
|
ram_size = 255;
|
|
}
|
|
d->config[I440FX_COREBOOT_RAM_SIZE] = ram_size;
|
|
|
|
i440fx_update_memory_mappings(f);
|
|
|
|
return b;
|
|
}
|
|
|
|
PCIBus *find_i440fx(void)
|
|
{
|
|
PCIHostState *s = OBJECT_CHECK(PCIHostState,
|
|
object_resolve_path("/machine/i440fx", NULL),
|
|
TYPE_PCI_HOST_BRIDGE);
|
|
return s ? s->bus : NULL;
|
|
}
|
|
|
|
static void i440fx_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
PCIDeviceClass *k = PCI_DEVICE_CLASS(klass);
|
|
|
|
k->realize = i440fx_realize;
|
|
k->config_write = i440fx_write_config;
|
|
k->vendor_id = PCI_VENDOR_ID_INTEL;
|
|
k->device_id = PCI_DEVICE_ID_INTEL_82441;
|
|
k->revision = 0x02;
|
|
k->class_id = PCI_CLASS_BRIDGE_HOST;
|
|
dc->desc = "Host bridge";
|
|
dc->vmsd = &vmstate_i440fx;
|
|
/*
|
|
* PCI-facing part of the host bridge, not usable without the
|
|
* host-facing part, which can't be device_add'ed, yet.
|
|
*/
|
|
dc->user_creatable = false;
|
|
dc->hotpluggable = false;
|
|
}
|
|
|
|
static const TypeInfo i440fx_info = {
|
|
.name = TYPE_I440FX_PCI_DEVICE,
|
|
.parent = TYPE_PCI_DEVICE,
|
|
.instance_size = sizeof(PCII440FXState),
|
|
.class_init = i440fx_class_init,
|
|
.interfaces = (InterfaceInfo[]) {
|
|
{ INTERFACE_CONVENTIONAL_PCI_DEVICE },
|
|
{ },
|
|
},
|
|
};
|
|
|
|
static const char *i440fx_pcihost_root_bus_path(PCIHostState *host_bridge,
|
|
PCIBus *rootbus)
|
|
{
|
|
I440FXState *s = I440FX_PCI_HOST_BRIDGE(host_bridge);
|
|
|
|
/* For backwards compat with old device paths */
|
|
if (s->short_root_bus) {
|
|
return "0000";
|
|
}
|
|
return "0000:00";
|
|
}
|
|
|
|
static Property i440fx_props[] = {
|
|
DEFINE_PROP_SIZE(PCI_HOST_PROP_PCI_HOLE64_SIZE, I440FXState,
|
|
pci_hole64_size, I440FX_PCI_HOST_HOLE64_SIZE_DEFAULT),
|
|
DEFINE_PROP_UINT32("short_root_bus", I440FXState, short_root_bus, 0),
|
|
DEFINE_PROP_BOOL("x-pci-hole64-fix", I440FXState, pci_hole64_fix, true),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void i440fx_pcihost_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
PCIHostBridgeClass *hc = PCI_HOST_BRIDGE_CLASS(klass);
|
|
|
|
hc->root_bus_path = i440fx_pcihost_root_bus_path;
|
|
dc->realize = i440fx_pcihost_realize;
|
|
dc->fw_name = "pci";
|
|
device_class_set_props(dc, i440fx_props);
|
|
/* Reason: needs to be wired up by pc_init1 */
|
|
dc->user_creatable = false;
|
|
}
|
|
|
|
static const TypeInfo i440fx_pcihost_info = {
|
|
.name = TYPE_I440FX_PCI_HOST_BRIDGE,
|
|
.parent = TYPE_PCI_HOST_BRIDGE,
|
|
.instance_size = sizeof(I440FXState),
|
|
.instance_init = i440fx_pcihost_initfn,
|
|
.class_init = i440fx_pcihost_class_init,
|
|
};
|
|
|
|
static void i440fx_register_types(void)
|
|
{
|
|
type_register_static(&i440fx_info);
|
|
type_register_static(&i440fx_pcihost_info);
|
|
}
|
|
|
|
type_init(i440fx_register_types)
|