Bin Meng ce8e43760e hw/net: fsl_etsec: Reverse the RCTRL.RSF logic ... Per MPC8548ERM [1] chapter 14.5.3.4.1: When RCTRL.RSF is 1, frames less than 64 bytes are accepted upon a DA match. But currently QEMU does the opposite. This commit reverses the RCTRL.RSF testing logic to match the manual. Due to the reverse of the logic, certain guests may potentially break if they don't program eTSEC to have RCTRL.RSF bit set. When RCTRL.RSF is 0, short frames are silently dropped, however as of today both slirp and tap networking do not pad short frames (e.g.: an ARP packet) to the minimum frame size of 60 bytes. So ARP requests will be dropped, preventing the guest from becoming visible on the network. The same issue was reported on e1000 and vmxenet3 before, see: commit 78aeb23ede ("e1000: Pad short frames to minimum size (60 bytes)") commit 40a87c6c9b ("vmxnet3: Pad short frames to minimum size (60 bytes)") [1] https://www.nxp.com/docs/en/reference-manual/MPC8548ERM.pdf Fixes: eb1e7c3e51 ("Add Enhanced Three-Speed Ethernet Controller (eTSEC)") Signed-off-by: Bin Meng <bin.meng@windriver.com> Message-Id: <1612923021-19746-1-git-send-email-bmeng.cn@gmail.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>		2021-02-10 14:50:11 +11:00
..
etsec.c	util/hexdump: Reorder qemu_hexdump() arguments	2020-09-11 21:25:59 +02:00
etsec.h	Use OBJECT_DECLARE_SIMPLE_TYPE when possible	2020-09-18 14:12:32 -04:00
miim.c	hw/net: Clean up includes	2016-01-29 15:07:23 +00:00
registers.c	hw/net: Clean up includes	2016-01-29 15:07:23 +00:00
registers.h	etsec: fix IRQ (un)masking	2018-07-16 11:18:09 +10:00
rings.c	hw/net: fsl_etsec: Reverse the RCTRL.RSF logic	2021-02-10 14:50:11 +11:00