e4ed1541ac
Code just now does (simplified for clarity)
if (qemu_savevm_state_iterate(s->file) == 1) {
vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
qemu_savevm_state_complete(s->file);
}
Problem here is that qemu_savevm_state_iterate() returns 1 when it
knows that remaining memory to sent takes less than max downtime.
But this means that we could end spending 2x max_downtime, one
downtime in qemu_savevm_iterate, and the other in
qemu_savevm_state_complete.
Changed code to:
pending_size = qemu_savevm_state_pending(s->file, max_size);
DPRINTF("pending size %lu max %lu\n", pending_size, max_size);
if (pending_size >= max_size) {
ret = qemu_savevm_state_iterate(s->file);
} else {
vm_stop_force_state(RUN_STATE_FINISH_MIGRATE);
qemu_savevm_state_complete(s->file);
}
So what we do is: at current network speed, we calculate the maximum
number of bytes we can sent: max_size.
Then we ask every save_live section how much they have pending. If
they are less than max_size, we move to complete phase, otherwise we
do an iterate one.
This makes things much simpler, because now individual sections don't
have to caluclate the bandwidth (it was implossible to do right from
there).
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
133 lines
3.7 KiB
C
133 lines
3.7 KiB
C
/*
|
|
* QEMU live migration
|
|
*
|
|
* Copyright IBM, Corp. 2008
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QEMU_MIGRATION_H
|
|
#define QEMU_MIGRATION_H
|
|
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "qemu-common.h"
|
|
#include "qemu/notify.h"
|
|
#include "qapi/error.h"
|
|
#include "migration/vmstate.h"
|
|
#include "qapi-types.h"
|
|
|
|
struct MigrationParams {
|
|
bool blk;
|
|
bool shared;
|
|
};
|
|
|
|
typedef struct MigrationState MigrationState;
|
|
|
|
struct MigrationState
|
|
{
|
|
int64_t bandwidth_limit;
|
|
QEMUFile *file;
|
|
int fd;
|
|
int state;
|
|
int (*get_error)(MigrationState *s);
|
|
int (*close)(MigrationState *s);
|
|
int (*write)(MigrationState *s, const void *buff, size_t size);
|
|
void *opaque;
|
|
MigrationParams params;
|
|
int64_t total_time;
|
|
int64_t downtime;
|
|
int64_t expected_downtime;
|
|
int64_t dirty_pages_rate;
|
|
bool enabled_capabilities[MIGRATION_CAPABILITY_MAX];
|
|
int64_t xbzrle_cache_size;
|
|
bool complete;
|
|
bool first_time;
|
|
};
|
|
|
|
void process_incoming_migration(QEMUFile *f);
|
|
|
|
void qemu_start_incoming_migration(const char *uri, Error **errp);
|
|
|
|
uint64_t migrate_max_downtime(void);
|
|
|
|
void do_info_migrate_print(Monitor *mon, const QObject *data);
|
|
|
|
void do_info_migrate(Monitor *mon, QObject **ret_data);
|
|
|
|
void exec_start_incoming_migration(const char *host_port, Error **errp);
|
|
|
|
void exec_start_outgoing_migration(MigrationState *s, const char *host_port, Error **errp);
|
|
|
|
void tcp_start_incoming_migration(const char *host_port, Error **errp);
|
|
|
|
void tcp_start_outgoing_migration(MigrationState *s, const char *host_port, Error **errp);
|
|
|
|
void unix_start_incoming_migration(const char *path, Error **errp);
|
|
|
|
void unix_start_outgoing_migration(MigrationState *s, const char *path, Error **errp);
|
|
|
|
void fd_start_incoming_migration(const char *path, Error **errp);
|
|
|
|
void fd_start_outgoing_migration(MigrationState *s, const char *fdname, Error **errp);
|
|
|
|
void migrate_fd_error(MigrationState *s);
|
|
|
|
void migrate_fd_connect(MigrationState *s);
|
|
|
|
ssize_t migrate_fd_put_buffer(MigrationState *s, const void *data,
|
|
size_t size);
|
|
bool migrate_fd_put_ready(MigrationState *s, uint64_t max_size);
|
|
int migrate_fd_close(MigrationState *s);
|
|
|
|
void add_migration_state_change_notifier(Notifier *notify);
|
|
void remove_migration_state_change_notifier(Notifier *notify);
|
|
bool migration_is_active(MigrationState *);
|
|
bool migration_has_finished(MigrationState *);
|
|
bool migration_has_failed(MigrationState *);
|
|
MigrationState *migrate_get_current(void);
|
|
|
|
uint64_t ram_bytes_remaining(void);
|
|
uint64_t ram_bytes_transferred(void);
|
|
uint64_t ram_bytes_total(void);
|
|
|
|
extern SaveVMHandlers savevm_ram_handlers;
|
|
|
|
uint64_t dup_mig_bytes_transferred(void);
|
|
uint64_t dup_mig_pages_transferred(void);
|
|
uint64_t norm_mig_bytes_transferred(void);
|
|
uint64_t norm_mig_pages_transferred(void);
|
|
uint64_t xbzrle_mig_bytes_transferred(void);
|
|
uint64_t xbzrle_mig_pages_transferred(void);
|
|
uint64_t xbzrle_mig_pages_overflow(void);
|
|
uint64_t xbzrle_mig_pages_cache_miss(void);
|
|
|
|
/**
|
|
* @migrate_add_blocker - prevent migration from proceeding
|
|
*
|
|
* @reason - an error to be returned whenever migration is attempted
|
|
*/
|
|
void migrate_add_blocker(Error *reason);
|
|
|
|
/**
|
|
* @migrate_del_blocker - remove a blocking error from migration
|
|
*
|
|
* @reason - the error blocking migration
|
|
*/
|
|
void migrate_del_blocker(Error *reason);
|
|
|
|
int xbzrle_encode_buffer(uint8_t *old_buf, uint8_t *new_buf, int slen,
|
|
uint8_t *dst, int dlen);
|
|
int xbzrle_decode_buffer(uint8_t *src, int slen, uint8_t *dst, int dlen);
|
|
|
|
int migrate_use_xbzrle(void);
|
|
int64_t migrate_xbzrle_cache_size(void);
|
|
|
|
int64_t xbzrle_cache_resize(int64_t new_size);
|
|
|
|
#endif
|