cannot_instantiate_with_device_add_yet was introduced by commit
efec3dd631
to replace no_user. It was
supposed to be a temporary measure.
When it was introduced, we had 54
cannot_instantiate_with_device_add_yet=true lines in the code.
Today (3 years later) this number has not shrunk: we now have
57 cannot_instantiate_with_device_add_yet=true lines. I think it
is safe to say it is not a temporary measure, and we won't see
the flag go away soon.
Instead of a long field name that misleads people to believe it
is temporary, replace it a shorter and less misleading field:
user_creatable.
Except for code comments, changes were generated using the
following Coccinelle patch:
@@
expression DC;
@@
(
-DC->cannot_instantiate_with_device_add_yet = false;
+DC->user_creatable = true;
|
-DC->cannot_instantiate_with_device_add_yet = true;
+DC->user_creatable = false;
)
@@
typedef ObjectClass;
expression dc;
identifier class, data;
@@
static void device_class_init(ObjectClass *class, void *data)
{
...
dc->hotpluggable = true;
+dc->user_creatable = true;
...
}
@@
@@
struct DeviceClass {
...
-bool cannot_instantiate_with_device_add_yet;
+bool user_creatable;
...
}
@@
expression DC;
@@
(
-!DC->cannot_instantiate_with_device_add_yet
+DC->user_creatable
|
-DC->cannot_instantiate_with_device_add_yet
+!DC->user_creatable
)
Cc: Alistair Francis <alistair.francis@xilinx.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>
Acked-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-2-ehabkost@redhat.com>
[ehabkost: kept "TODO remove once we're there" comment]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
185 lines
5.3 KiB
C
185 lines
5.3 KiB
C
/*
|
|
* QEMU AMD PC-Net II (Am79C970A) emulation
|
|
*
|
|
* Copyright (c) 2004 Antony T Curtis
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
/* This software was written to be compatible with the specification:
|
|
* AMD Am79C970A PCnet-PCI II Ethernet Controller Data-Sheet
|
|
* AMD Publication# 19436 Rev:E Amendment/0 Issue Date: June 2000
|
|
*/
|
|
|
|
/*
|
|
* On Sparc32, this is the Lance (Am7990) part of chip STP2000 (Master I/O), also
|
|
* produced as NCR89C100. See
|
|
* http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR89C100.txt
|
|
* and
|
|
* http://www.ibiblio.org/pub/historic-linux/early-ports/Sparc/NCR/NCR92C990.txt
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/sysbus.h"
|
|
#include "net/net.h"
|
|
#include "qemu/timer.h"
|
|
#include "qemu/sockets.h"
|
|
#include "hw/sparc/sun4m.h"
|
|
#include "pcnet.h"
|
|
#include "trace.h"
|
|
#include "sysemu/sysemu.h"
|
|
|
|
#define TYPE_LANCE "lance"
|
|
#define SYSBUS_PCNET(obj) \
|
|
OBJECT_CHECK(SysBusPCNetState, (obj), TYPE_LANCE)
|
|
|
|
typedef struct {
|
|
SysBusDevice parent_obj;
|
|
|
|
PCNetState state;
|
|
} SysBusPCNetState;
|
|
|
|
static void parent_lance_reset(void *opaque, int irq, int level)
|
|
{
|
|
SysBusPCNetState *d = opaque;
|
|
if (level)
|
|
pcnet_h_reset(&d->state);
|
|
}
|
|
|
|
static void lance_mem_write(void *opaque, hwaddr addr,
|
|
uint64_t val, unsigned size)
|
|
{
|
|
SysBusPCNetState *d = opaque;
|
|
|
|
trace_lance_mem_writew(addr, val & 0xffff);
|
|
pcnet_ioport_writew(&d->state, addr, val & 0xffff);
|
|
}
|
|
|
|
static uint64_t lance_mem_read(void *opaque, hwaddr addr,
|
|
unsigned size)
|
|
{
|
|
SysBusPCNetState *d = opaque;
|
|
uint32_t val;
|
|
|
|
val = pcnet_ioport_readw(&d->state, addr);
|
|
trace_lance_mem_readw(addr, val & 0xffff);
|
|
return val & 0xffff;
|
|
}
|
|
|
|
static const MemoryRegionOps lance_mem_ops = {
|
|
.read = lance_mem_read,
|
|
.write = lance_mem_write,
|
|
.endianness = DEVICE_NATIVE_ENDIAN,
|
|
.valid = {
|
|
.min_access_size = 2,
|
|
.max_access_size = 2,
|
|
},
|
|
};
|
|
|
|
static NetClientInfo net_lance_info = {
|
|
.type = NET_CLIENT_DRIVER_NIC,
|
|
.size = sizeof(NICState),
|
|
.receive = pcnet_receive,
|
|
.link_status_changed = pcnet_set_link_status,
|
|
};
|
|
|
|
static const VMStateDescription vmstate_lance = {
|
|
.name = "pcnet",
|
|
.version_id = 3,
|
|
.minimum_version_id = 2,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_STRUCT(state, SysBusPCNetState, 0, vmstate_pcnet, PCNetState),
|
|
VMSTATE_END_OF_LIST()
|
|
}
|
|
};
|
|
|
|
static int lance_init(SysBusDevice *sbd)
|
|
{
|
|
DeviceState *dev = DEVICE(sbd);
|
|
SysBusPCNetState *d = SYSBUS_PCNET(dev);
|
|
PCNetState *s = &d->state;
|
|
|
|
memory_region_init_io(&s->mmio, OBJECT(d), &lance_mem_ops, d,
|
|
"lance-mmio", 4);
|
|
|
|
qdev_init_gpio_in(dev, parent_lance_reset, 1);
|
|
|
|
sysbus_init_mmio(sbd, &s->mmio);
|
|
|
|
sysbus_init_irq(sbd, &s->irq);
|
|
|
|
s->phys_mem_read = ledma_memory_read;
|
|
s->phys_mem_write = ledma_memory_write;
|
|
pcnet_common_init(dev, s, &net_lance_info);
|
|
return 0;
|
|
}
|
|
|
|
static void lance_reset(DeviceState *dev)
|
|
{
|
|
SysBusPCNetState *d = SYSBUS_PCNET(dev);
|
|
|
|
pcnet_h_reset(&d->state);
|
|
}
|
|
|
|
static void lance_instance_init(Object *obj)
|
|
{
|
|
SysBusPCNetState *d = SYSBUS_PCNET(obj);
|
|
PCNetState *s = &d->state;
|
|
|
|
device_add_bootindex_property(obj, &s->conf.bootindex,
|
|
"bootindex", "/ethernet-phy@0",
|
|
DEVICE(obj), NULL);
|
|
}
|
|
|
|
static Property lance_properties[] = {
|
|
DEFINE_PROP_PTR("dma", SysBusPCNetState, state.dma_opaque),
|
|
DEFINE_NIC_PROPERTIES(SysBusPCNetState, state.conf),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void lance_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
SysBusDeviceClass *k = SYS_BUS_DEVICE_CLASS(klass);
|
|
|
|
k->init = lance_init;
|
|
set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
|
|
dc->fw_name = "ethernet";
|
|
dc->reset = lance_reset;
|
|
dc->vmsd = &vmstate_lance;
|
|
dc->props = lance_properties;
|
|
/* Reason: pointer property "dma" */
|
|
dc->user_creatable = false;
|
|
}
|
|
|
|
static const TypeInfo lance_info = {
|
|
.name = TYPE_LANCE,
|
|
.parent = TYPE_SYS_BUS_DEVICE,
|
|
.instance_size = sizeof(SysBusPCNetState),
|
|
.class_init = lance_class_init,
|
|
.instance_init = lance_instance_init,
|
|
};
|
|
|
|
static void lance_register_types(void)
|
|
{
|
|
type_register_static(&lance_info);
|
|
}
|
|
|
|
type_init(lance_register_types)
|