49d741b504
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. iotests 165 was rather weak - on a default 64k-cluster image, where bitmap granularity also defaults to 64k bytes, a single cluster of the bitmap table thus covers (64*1024*8) bits which each cover 64k bytes, or 32G of image space. But the test only uses a 1G image, so it cannot trigger any more than one loop of the code in store_bitmap_data(); and it was writing to the first cluster. In order to test that we are properly aligning which portions of the bitmap are being written to the file, we really want to test a case where the first dirty bit returned by bdrv_dirty_iter_next() is not aligned to the start of a cluster, which we can do by modifying the test to write data that doesn't happen to fall in the first cluster of the image. Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> Reviewed-by: John Snow <jsnow@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
106 lines
3 KiB
Python
Executable file
106 lines
3 KiB
Python
Executable file
#!/usr/bin/env python
|
|
#
|
|
# Tests for persistent dirty bitmaps.
|
|
#
|
|
# Copyright: Vladimir Sementsov-Ogievskiy 2015-2017
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
import os
|
|
import re
|
|
import iotests
|
|
from iotests import qemu_img
|
|
|
|
disk = os.path.join(iotests.test_dir, 'disk')
|
|
disk_size = 0x40000000 # 1G
|
|
|
|
# regions for qemu_io: (start, count) in bytes
|
|
regions1 = ((0x0fff00, 0x10000),
|
|
(0x200000, 0x100000))
|
|
|
|
regions2 = ((0x10000000, 0x20000),
|
|
(0x3fff0000, 0x10000))
|
|
|
|
class TestPersistentDirtyBitmap(iotests.QMPTestCase):
|
|
|
|
def setUp(self):
|
|
qemu_img('create', '-f', iotests.imgfmt, disk, str(disk_size))
|
|
|
|
def tearDown(self):
|
|
os.remove(disk)
|
|
|
|
def mkVm(self):
|
|
return iotests.VM().add_drive(disk)
|
|
|
|
def mkVmRo(self):
|
|
return iotests.VM().add_drive(disk, opts='readonly=on')
|
|
|
|
def getSha256(self):
|
|
result = self.vm.qmp('x-debug-block-dirty-bitmap-sha256',
|
|
node='drive0', name='bitmap0')
|
|
return result['return']['sha256']
|
|
|
|
def checkBitmap(self, sha256):
|
|
result = self.vm.qmp('x-debug-block-dirty-bitmap-sha256',
|
|
node='drive0', name='bitmap0')
|
|
self.assert_qmp(result, 'return/sha256', sha256);
|
|
|
|
def writeRegions(self, regions):
|
|
for r in regions:
|
|
self.vm.hmp_qemu_io('drive0',
|
|
'write %d %d' % r)
|
|
|
|
def qmpAddBitmap(self):
|
|
self.vm.qmp('block-dirty-bitmap-add', node='drive0',
|
|
name='bitmap0', persistent=True, autoload=True)
|
|
|
|
def test_persistent(self):
|
|
self.vm = self.mkVm()
|
|
self.vm.launch()
|
|
self.qmpAddBitmap()
|
|
|
|
self.writeRegions(regions1)
|
|
sha256 = self.getSha256()
|
|
|
|
self.vm.shutdown()
|
|
|
|
self.vm = self.mkVmRo()
|
|
self.vm.launch()
|
|
self.vm.shutdown()
|
|
|
|
#catch 'Persistent bitmaps are lost' possible error
|
|
log = self.vm.get_log()
|
|
log = re.sub(r'^\[I \d+\.\d+\] OPENED\n', '', log)
|
|
log = re.sub(r'\[I \+\d+\.\d+\] CLOSED\n?$', '', log)
|
|
if log:
|
|
print log
|
|
|
|
self.vm = self.mkVm()
|
|
self.vm.launch()
|
|
|
|
self.checkBitmap(sha256)
|
|
self.writeRegions(regions2)
|
|
sha256 = self.getSha256()
|
|
|
|
self.vm.shutdown()
|
|
self.vm.launch()
|
|
|
|
self.checkBitmap(sha256)
|
|
|
|
self.vm.shutdown()
|
|
|
|
if __name__ == '__main__':
|
|
iotests.main(supported_fmts=['qcow2'])
|