cannot_instantiate_with_device_add_yet was introduced by commit
efec3dd631
to replace no_user. It was
supposed to be a temporary measure.
When it was introduced, we had 54
cannot_instantiate_with_device_add_yet=true lines in the code.
Today (3 years later) this number has not shrunk: we now have
57 cannot_instantiate_with_device_add_yet=true lines. I think it
is safe to say it is not a temporary measure, and we won't see
the flag go away soon.
Instead of a long field name that misleads people to believe it
is temporary, replace it a shorter and less misleading field:
user_creatable.
Except for code comments, changes were generated using the
following Coccinelle patch:
@@
expression DC;
@@
(
-DC->cannot_instantiate_with_device_add_yet = false;
+DC->user_creatable = true;
|
-DC->cannot_instantiate_with_device_add_yet = true;
+DC->user_creatable = false;
)
@@
typedef ObjectClass;
expression dc;
identifier class, data;
@@
static void device_class_init(ObjectClass *class, void *data)
{
...
dc->hotpluggable = true;
+dc->user_creatable = true;
...
}
@@
@@
struct DeviceClass {
...
-bool cannot_instantiate_with_device_add_yet;
+bool user_creatable;
...
}
@@
expression DC;
@@
(
-!DC->cannot_instantiate_with_device_add_yet
+DC->user_creatable
|
-DC->cannot_instantiate_with_device_add_yet
+!DC->user_creatable
)
Cc: Alistair Francis <alistair.francis@xilinx.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>
Acked-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-2-ehabkost@redhat.com>
[ehabkost: kept "TODO remove once we're there" comment]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
381 lines
9.6 KiB
C
381 lines
9.6 KiB
C
/*
|
|
* QEMU GRLIB IRQMP Emulator
|
|
*
|
|
* (Multiprocessor and extended interrupt not supported)
|
|
*
|
|
* Copyright (c) 2010-2011 AdaCore
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/sysbus.h"
|
|
#include "cpu.h"
|
|
|
|
#include "hw/sparc/grlib.h"
|
|
|
|
#include "trace.h"
|
|
#include "qapi/error.h"
|
|
|
|
#define IRQMP_MAX_CPU 16
|
|
#define IRQMP_REG_SIZE 256 /* Size of memory mapped registers */
|
|
|
|
/* Memory mapped register offsets */
|
|
#define LEVEL_OFFSET 0x00
|
|
#define PENDING_OFFSET 0x04
|
|
#define FORCE0_OFFSET 0x08
|
|
#define CLEAR_OFFSET 0x0C
|
|
#define MP_STATUS_OFFSET 0x10
|
|
#define BROADCAST_OFFSET 0x14
|
|
#define MASK_OFFSET 0x40
|
|
#define FORCE_OFFSET 0x80
|
|
#define EXTENDED_OFFSET 0xC0
|
|
|
|
#define TYPE_GRLIB_IRQMP "grlib,irqmp"
|
|
#define GRLIB_IRQMP(obj) OBJECT_CHECK(IRQMP, (obj), TYPE_GRLIB_IRQMP)
|
|
|
|
typedef struct IRQMPState IRQMPState;
|
|
|
|
typedef struct IRQMP {
|
|
SysBusDevice parent_obj;
|
|
|
|
MemoryRegion iomem;
|
|
|
|
void *set_pil_in;
|
|
void *set_pil_in_opaque;
|
|
|
|
IRQMPState *state;
|
|
} IRQMP;
|
|
|
|
struct IRQMPState {
|
|
uint32_t level;
|
|
uint32_t pending;
|
|
uint32_t clear;
|
|
uint32_t broadcast;
|
|
|
|
uint32_t mask[IRQMP_MAX_CPU];
|
|
uint32_t force[IRQMP_MAX_CPU];
|
|
uint32_t extended[IRQMP_MAX_CPU];
|
|
|
|
IRQMP *parent;
|
|
};
|
|
|
|
static void grlib_irqmp_check_irqs(IRQMPState *state)
|
|
{
|
|
uint32_t pend = 0;
|
|
uint32_t level0 = 0;
|
|
uint32_t level1 = 0;
|
|
set_pil_in_fn set_pil_in;
|
|
|
|
assert(state != NULL);
|
|
assert(state->parent != NULL);
|
|
|
|
/* IRQ for CPU 0 (no SMP support) */
|
|
pend = (state->pending | state->force[0])
|
|
& state->mask[0];
|
|
|
|
level0 = pend & ~state->level;
|
|
level1 = pend & state->level;
|
|
|
|
trace_grlib_irqmp_check_irqs(state->pending, state->force[0],
|
|
state->mask[0], level1, level0);
|
|
|
|
set_pil_in = (set_pil_in_fn)state->parent->set_pil_in;
|
|
|
|
/* Trigger level1 interrupt first and level0 if there is no level1 */
|
|
if (level1 != 0) {
|
|
set_pil_in(state->parent->set_pil_in_opaque, level1);
|
|
} else {
|
|
set_pil_in(state->parent->set_pil_in_opaque, level0);
|
|
}
|
|
}
|
|
|
|
void grlib_irqmp_ack(DeviceState *dev, int intno)
|
|
{
|
|
IRQMP *irqmp = GRLIB_IRQMP(dev);
|
|
IRQMPState *state;
|
|
uint32_t mask;
|
|
|
|
state = irqmp->state;
|
|
assert(state != NULL);
|
|
|
|
intno &= 15;
|
|
mask = 1 << intno;
|
|
|
|
trace_grlib_irqmp_ack(intno);
|
|
|
|
/* Clear registers */
|
|
state->pending &= ~mask;
|
|
state->force[0] &= ~mask; /* Only CPU 0 (No SMP support) */
|
|
|
|
grlib_irqmp_check_irqs(state);
|
|
}
|
|
|
|
void grlib_irqmp_set_irq(void *opaque, int irq, int level)
|
|
{
|
|
IRQMP *irqmp = GRLIB_IRQMP(opaque);
|
|
IRQMPState *s;
|
|
int i = 0;
|
|
|
|
s = irqmp->state;
|
|
assert(s != NULL);
|
|
assert(s->parent != NULL);
|
|
|
|
|
|
if (level) {
|
|
trace_grlib_irqmp_set_irq(irq);
|
|
|
|
if (s->broadcast & 1 << irq) {
|
|
/* Broadcasted IRQ */
|
|
for (i = 0; i < IRQMP_MAX_CPU; i++) {
|
|
s->force[i] |= 1 << irq;
|
|
}
|
|
} else {
|
|
s->pending |= 1 << irq;
|
|
}
|
|
grlib_irqmp_check_irqs(s);
|
|
|
|
}
|
|
}
|
|
|
|
static uint64_t grlib_irqmp_read(void *opaque, hwaddr addr,
|
|
unsigned size)
|
|
{
|
|
IRQMP *irqmp = opaque;
|
|
IRQMPState *state;
|
|
|
|
assert(irqmp != NULL);
|
|
state = irqmp->state;
|
|
assert(state != NULL);
|
|
|
|
addr &= 0xff;
|
|
|
|
/* global registers */
|
|
switch (addr) {
|
|
case LEVEL_OFFSET:
|
|
return state->level;
|
|
|
|
case PENDING_OFFSET:
|
|
return state->pending;
|
|
|
|
case FORCE0_OFFSET:
|
|
/* This register is an "alias" for the force register of CPU 0 */
|
|
return state->force[0];
|
|
|
|
case CLEAR_OFFSET:
|
|
case MP_STATUS_OFFSET:
|
|
/* Always read as 0 */
|
|
return 0;
|
|
|
|
case BROADCAST_OFFSET:
|
|
return state->broadcast;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
/* mask registers */
|
|
if (addr >= MASK_OFFSET && addr < FORCE_OFFSET) {
|
|
int cpu = (addr - MASK_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
return state->mask[cpu];
|
|
}
|
|
|
|
/* force registers */
|
|
if (addr >= FORCE_OFFSET && addr < EXTENDED_OFFSET) {
|
|
int cpu = (addr - FORCE_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
return state->force[cpu];
|
|
}
|
|
|
|
/* extended (not supported) */
|
|
if (addr >= EXTENDED_OFFSET && addr < IRQMP_REG_SIZE) {
|
|
int cpu = (addr - EXTENDED_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
return state->extended[cpu];
|
|
}
|
|
|
|
trace_grlib_irqmp_readl_unknown(addr);
|
|
return 0;
|
|
}
|
|
|
|
static void grlib_irqmp_write(void *opaque, hwaddr addr,
|
|
uint64_t value, unsigned size)
|
|
{
|
|
IRQMP *irqmp = opaque;
|
|
IRQMPState *state;
|
|
|
|
assert(irqmp != NULL);
|
|
state = irqmp->state;
|
|
assert(state != NULL);
|
|
|
|
addr &= 0xff;
|
|
|
|
/* global registers */
|
|
switch (addr) {
|
|
case LEVEL_OFFSET:
|
|
value &= 0xFFFF << 1; /* clean up the value */
|
|
state->level = value;
|
|
return;
|
|
|
|
case PENDING_OFFSET:
|
|
/* Read Only */
|
|
return;
|
|
|
|
case FORCE0_OFFSET:
|
|
/* This register is an "alias" for the force register of CPU 0 */
|
|
|
|
value &= 0xFFFE; /* clean up the value */
|
|
state->force[0] = value;
|
|
grlib_irqmp_check_irqs(irqmp->state);
|
|
return;
|
|
|
|
case CLEAR_OFFSET:
|
|
value &= ~1; /* clean up the value */
|
|
state->pending &= ~value;
|
|
return;
|
|
|
|
case MP_STATUS_OFFSET:
|
|
/* Read Only (no SMP support) */
|
|
return;
|
|
|
|
case BROADCAST_OFFSET:
|
|
value &= 0xFFFE; /* clean up the value */
|
|
state->broadcast = value;
|
|
return;
|
|
|
|
default:
|
|
break;
|
|
}
|
|
|
|
/* mask registers */
|
|
if (addr >= MASK_OFFSET && addr < FORCE_OFFSET) {
|
|
int cpu = (addr - MASK_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
value &= ~1; /* clean up the value */
|
|
state->mask[cpu] = value;
|
|
grlib_irqmp_check_irqs(irqmp->state);
|
|
return;
|
|
}
|
|
|
|
/* force registers */
|
|
if (addr >= FORCE_OFFSET && addr < EXTENDED_OFFSET) {
|
|
int cpu = (addr - FORCE_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
uint32_t force = value & 0xFFFE;
|
|
uint32_t clear = (value >> 16) & 0xFFFE;
|
|
uint32_t old = state->force[cpu];
|
|
|
|
state->force[cpu] = (old | force) & ~clear;
|
|
grlib_irqmp_check_irqs(irqmp->state);
|
|
return;
|
|
}
|
|
|
|
/* extended (not supported) */
|
|
if (addr >= EXTENDED_OFFSET && addr < IRQMP_REG_SIZE) {
|
|
int cpu = (addr - EXTENDED_OFFSET) / 4;
|
|
assert(cpu >= 0 && cpu < IRQMP_MAX_CPU);
|
|
|
|
value &= 0xF; /* clean up the value */
|
|
state->extended[cpu] = value;
|
|
return;
|
|
}
|
|
|
|
trace_grlib_irqmp_writel_unknown(addr, value);
|
|
}
|
|
|
|
static const MemoryRegionOps grlib_irqmp_ops = {
|
|
.read = grlib_irqmp_read,
|
|
.write = grlib_irqmp_write,
|
|
.endianness = DEVICE_NATIVE_ENDIAN,
|
|
.valid = {
|
|
.min_access_size = 4,
|
|
.max_access_size = 4,
|
|
},
|
|
};
|
|
|
|
static void grlib_irqmp_reset(DeviceState *d)
|
|
{
|
|
IRQMP *irqmp = GRLIB_IRQMP(d);
|
|
assert(irqmp->state != NULL);
|
|
|
|
memset(irqmp->state, 0, sizeof *irqmp->state);
|
|
irqmp->state->parent = irqmp;
|
|
}
|
|
|
|
static void grlib_irqmp_init(Object *obj)
|
|
{
|
|
IRQMP *irqmp = GRLIB_IRQMP(obj);
|
|
SysBusDevice *dev = SYS_BUS_DEVICE(obj);
|
|
|
|
memory_region_init_io(&irqmp->iomem, obj, &grlib_irqmp_ops, irqmp,
|
|
"irqmp", IRQMP_REG_SIZE);
|
|
|
|
irqmp->state = g_malloc0(sizeof *irqmp->state);
|
|
|
|
sysbus_init_mmio(dev, &irqmp->iomem);
|
|
}
|
|
|
|
static void grlib_irqmp_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
IRQMP *irqmp = GRLIB_IRQMP(dev);
|
|
|
|
/* Check parameters */
|
|
if (irqmp->set_pil_in == NULL) {
|
|
error_setg(errp, "set_pil_in cannot be NULL.");
|
|
}
|
|
}
|
|
|
|
static Property grlib_irqmp_properties[] = {
|
|
DEFINE_PROP_PTR("set_pil_in", IRQMP, set_pil_in),
|
|
DEFINE_PROP_PTR("set_pil_in_opaque", IRQMP, set_pil_in_opaque),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void grlib_irqmp_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->reset = grlib_irqmp_reset;
|
|
dc->props = grlib_irqmp_properties;
|
|
/* Reason: pointer properties "set_pil_in", "set_pil_in_opaque" */
|
|
dc->user_creatable = false;
|
|
dc->realize = grlib_irqmp_realize;
|
|
}
|
|
|
|
static const TypeInfo grlib_irqmp_info = {
|
|
.name = TYPE_GRLIB_IRQMP,
|
|
.parent = TYPE_SYS_BUS_DEVICE,
|
|
.instance_size = sizeof(IRQMP),
|
|
.instance_init = grlib_irqmp_init,
|
|
.class_init = grlib_irqmp_class_init,
|
|
};
|
|
|
|
static void grlib_irqmp_register_types(void)
|
|
{
|
|
type_register_static(&grlib_irqmp_info);
|
|
}
|
|
|
|
type_init(grlib_irqmp_register_types)
|