do not duplicate the result of method calls into a NSMutableString

2012-10-30 08:49:51 -04:00 · 2012-10-30 08:49:51 -04:00 · 806ea9fd13
parent 40a1a51845
commit 806ea9fd13
1 changed files with 4 additions and 7 deletions
--- a/SOPE/GDLContentStore/GCSFolder.m
+++ b/SOPE/GDLContentStore/GCSFolder.m
@ -351,15 +351,12 @@ static GCSStringFormatter *stringFormatter = nil;
 - (NSString *) _selectedFields: (NSArray *) fields
 		   requirement: (GCSTableRequirement) requirement
 {
-  NSMutableString *selectedFields;
-
-  selectedFields = [NSMutableString string];
+  NSString *selectedFields;
  
-  if (requirement == bothTableRequired
-      && [fields containsObject: @"c_name"])
-    [selectedFields appendString: [self _dottedFields: fields]];
+  if (requirement == bothTableRequired && [fields containsObject: @"c_name"])
+    selectedFields = [self _dottedFields: fields];
  else
-    [selectedFields appendString: [fields componentsJoinedByString: @", "]];
+    selectedFields = [fields componentsJoinedByString: @", "];

  return selectedFields;
 }