this is visible even with hello-world.odt in the debugging overlay where
I have 9 cols and 7 rows visible.
Load hello-world.odt and from the 4th row, 8th col onwards each tile has
a "upd: 1" of an additional empty delta update to the original tile
browser-side:
a) we have one OUTGOING: tilecombine request which which requests an
initial 72 tiles (9 cols, 8 rows)
b) we then receive 72 tiles as requested
c) and browser sends back tileprocessed for each
d) but we then get a series of (38) delta: requests after that which are
unexplained
server-side:
a) on the initial tilecombine, DocumentBroker::handleTileCombinedRequest
sends the 72 requested tiles for rendering and registers to send each when
ready.
for (auto& tile : tileCombined.getTiles())
{
...
tilesNeedsRendering.push_back(tile);
...
tileCache().subscribeToTileRendering(tile, session, now);
}
// Send rendering request, prerender before we actually send the tiles
if (!tilesNeedsRendering.empty())
sendTileCombine(TileCombined::create(tilesNeedsRendering));
and stores what tiles it want to send in session->getRequestedTiles()
before calling sendRequestedTiles(session);
b) at this sendRequestedTiles (also later when tileprocessed is seen from
each tile response from the browser which also calls sendRequestedTiles), then:
c) DocumentBroker::sendRequestedTiles loops over existing requests and drops
from session->getRequestedTiles() both the tiles that it can send immediately,
and those that are queued to get rendered.
d) But it only does this for a max amount of tiles, based on beingRendered, up to
a tilesOnFlyUpperLimit. beingRendered is bumped for each tile not ready yet,
on the assumption that it needs to be rendered.
e) But we already have some getting rendered, and bump beingRendered anyway,
so tilesOnFlyUpperLimit can easily get exceeded on a first page, typically this
first sendRequestedTiles loop stops early, and stops dropping tiles from the
request queue that are already queued to be rendered.
f) at some point we get a tileprocessed and sendRequestedTiles is called again,
the request queue wasn't emptied, and by now it is likely the tile cache has
results for them (which were already sent) and sendTileNow is used to send those,
resulting in additional empty deltas sent for fulfilled queries.
logs will show "Redundant request to subscribe on tile" warnings in this case
Here as a conservative improvement only increase beingRendered if the sendRequestedTiles
subscribeToTileRendering actually does anything.
There is a mismatch in what handleTileCombinedRequest does vs what
sendRequestedTiles does. Maybe handleTileCombinedRequest should leave it
to sendRequestedTiles to do the sendTileCombine, or maybe
handleTileCombinedRequest shouldn't add those tiles to the session
requestedTiles.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I3044f4b3e47f00c680aa5b87dd7bdad2f27e8c73
It seems that datepicker control expects only a language input
in regional property (e.g. fr) instead of language-country (e.g. fr-FR).
Signed-off-by: Gabriel Masei <gabriel.masei@1and1.ro>
Change-Id: I7d5ac40cfa4a72cdc7862a8b4c4d14bdecad6c3b
When a document is loaded the Accessibility Support toggle button was
not set to the right state.
The problem affeced Online when integrated in Nextcloud.
Moreover the button label has been renamed to 'Voice Over' in
accordance with what suggested by NGI audit
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I5bc7d8348397691f469b6274af58e18a8d6d603c
At the moment, we try to detect whether the browser is running with a
touchscreen, however this is very imperfect. It's possible an integrator
may have more information about whether COOL is running on a device with
a touchscreen, so this ui_defaults option allows us to specify. Touch
mode binds inputs for touchscreen devices (long press for menu, pinch to
zoom, etc.) and does not bind the normal inputs (right click for menu,
etc.), so it's crucial to get it on all touch devices and no desktop
devices, as input is severely hampered if they are the wrong way round.
The option is called TouchscreenHint. Setting it to 'true' will enable
touchscreen mode, setting it to 'false' will disable touchscreen mode.
Leaving it undefined will keep our detection active.
This option must be set at page load so we can register the right
events at creation time. Therefore, ui_defaults is perfect as a method
to override this.
This is not a long-term solution. Instead, "The right thing" is to look
specifically for touch events and specifically for mouse events, rather
than using the default hammer.js behavior which is to look for both...
that should be an eventual followup to this. However, this was a lot
faster to implement and helps with the most pressing issue: not being
able to override our detection when it goes wrong.
Change-Id: Id28a156fe352fe6565ce6b472b7aa54d0869c48e
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
This is now safe to show, as it'll trigger the frame insert/properties
dialog, which was converted to jsdialog in core.git commit
355681eead2411d70caf4f52f1b802cf8c61a981 (sw floattable: make Insert
Frame dialog async and mark it as a jsdialog, 2023-11-06).
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I910012286416231d607cf79cc9b3811803c52768
A slide preview tile falls into the special case with early return and
no tileprocessed is sent back to the server, so eventually a
'Tileprocessed message did not arrive in time' will be reported
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Iab85e5eca535ce377508e91cf67f1435e9242bc4
problem:
when user copy cell with formula and paste it outside of online,
formulas are pasted instead of values.
Ideally we should always put real value in client clipboard
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I93af2fffa501c3cdc3d8ecc78d3c44121784d3e8
This allows the creation of floating tables when an entire table is
selected by the time we dispatch .uno:InsertFrame.
Also add a matching entry in the menubar.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ia0614d47275eb8d9127c496a0b06a8993c5f9989
It was reported on some iOS devices that we fail with TypeError
in getCorePxDocBounds - missing this.options.docBounds.
getCorePxDocBounds is used in Cursor class, check if we have
docBounds before use so we don't try to update without valid
data
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia48738edac33ab272e338e23f0d71f7ec4f54086
Currently translated at 63.3% (340 of 537 strings)
Translated using Weblate (Norwegian Bokmål)
Currently translated at 61.6% (331 of 537 strings)
Translated using Weblate (Norwegian Bokmål)
Currently translated at 100.0% (5 of 5 strings)
Translated using Weblate (Norwegian Bokmål)
Currently translated at 59.4% (319 of 537 strings)
Translated using Weblate (Norwegian Bokmål)
Currently translated at 100.0% (22 of 22 strings)
Co-authored-by: DPE <danpe_jobo@hotmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/nb_NO/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ios-app/nb_NO/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nb_NO/
Translation: Collabora Online/Android lib
Translation: Collabora Online/UI
Translation: Collabora Online/iOS app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Iaabb7ffb88433e624d58dad43f3fbadd5aacd681
Currently translated at 100.0% (537 of 537 strings)
Translated using Weblate (Croatian)
Currently translated at 99.8% (536 of 537 strings)
Co-authored-by: Milo Ivir <mail@milotype.de>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/hr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I72997ea8388b0047305b9b77ca73cf29b0333f27
- This will fix not to check or uncheck if a checkbox is disabled by clicking on a lable of a checkbox
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I3c6f770058ae1409f56d6bd12f5e7a8cd2441941
* Add a paragraph.
* Select the whole paragraph and add comment.
* Add hyperlink to a word in the paragraph.
* Try to copy the hyperlink via its menu.
* It sometimes doesn't copy the hyperlink.
We are checking if a comment has focus or not before doing the copy operation. This check is for another issue.
I changed the check with "app.view.commentHasFocus" which seems reliable.
Then tested the previous fix.
Also commented out code is removed.
White space change is automatic.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ibc2c5e550eb8a3e24b734e0371c87dac44b2ff6d
The new ui_defaults option OnscreenKeyboardHint is a tristate denoting
whether the device accessing Collabora Online has an onscreen keyboard
If unset, Collabora Online will do its best to guess. At time of
writing, this is the same as checking if the device is a mobile phone
or a tablet (note: only tablets which have the browser registered as a
"mobile" browser will be detected, e.g. the Microsoft Surface tablets
would not be detected)
If "true", Collabora will assume the device has an onscreen keyboard.
This will change when we trigger the keyboard, for example in calc if we
know of an onscreen keyboard we will not automatically focus a cell for
editing when it is selected, as this would pop up the keyboard.
If "false", Collabora will assume the device does not have an onscreen
keyboard, effectively doing the inverse of the "true" option above.
This is a followup to #7580 (0bf054c9a3)
which had Hint_OnscreenKeyboard and Hint_NoOnscreenKeyboard as
postmessage IDs to do the same thing.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I5deeb87a410c135d4cabda7ed24dc37e791800cd
doesn't happen in ci, but is happening in tinderbox and for some
users.
Seeing as ScrollSection doesn't have the problem, follow the export
and namespace pattern used there.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I4c4916ba7a3ad19275bd8b0f5bc53111b3b30cd5
Caolán McNamara
Marco Cecchetti
Gabriel Masei
Andras Timar
Skyler Grey
TUCAOEVER5023416dba724da7
Matthaiks
Milo Ivir
Louis Chance
gallegonovato
Miklos Vajna
Pranam Lashkari
Gökay Şatır
Szymon Kłos
DPE
Ihor Hordiichuk
Besnik Bleta
Sebastiaan Veld
Martin Srebotnjak
m4skedbyte
Ettore Atalan
Qiao Yifeng
Ayhan Yalçınsoy
bittin1ddc447d824349b2
SC
Rob Pearson
Stanislav Horáček
Darshan-upadhyay1110
Hubert Figuière