We also set the variable on the core side in order to allow saving edited documents.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I9ba97daca7013bf26b25fff785f175e3fb213dfb
This is implemented in two cases:
* using a request parameter '&startPresentation=true'
* for ppsx/pps for which the backend sends a startPresentation
stateChange event. This can be overridden passing
'&startPresentation=false' to allow editing the file.
The presentation can only start in present-in-window mode due to browser
gating fullscreen by user activation.
Refactor SlideShow._onFullScreen to better handle the requestFullscreen permission restriction failing case.
Also clean up old references to old restricted implementations.
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I98fcb1a7da170fa1c6a7de75c680259163233c9d
Move debug toggle to after docloaded message
Move sidebar toggle even later than that
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ib72b5ef4c2c31f7707a384b2d819d5cde57a796d
problem:
when using display scaling/zooming clicking on comment may cause
overlapping on comments if the previous comment from clicked comment is long
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6e9eec3ba5c3fb9f871ce42bb0a554d7e2cc3c5e
We don't need a SocketPoll and its wake-pipes before we
run a test - obviously, and we should close it when we
fork a new test.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I56875b66ce2ba141baacdd70c973e9e9af02d1d0
Don't leave the wake-pipes lying around; it can't do any good
to have these cloned, and shared between child processes.
Change-Id: Ieb6c5c8fdd1285bc514116a1e00de76bcc5a1773
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
On fork a thread_local variable simply inherits the parents'
value - so clearing the cached thread_id helps to make
logging more accurate.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ib03d2605489291589854caa10940fd7c11caea36
This may not look hyper-elegant, but using ~Socket to do this
calls 'shutdown' first on the sockets, which closes the parent's
duplicate of the socket very unhelpfully. So close instead.
Don't touch and thus COW memory. We will leave the Socket Poll
around un-used, and un-polling from eg. the ForKit in the Kit
process.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I1328dee0278ce39350194c617acffa114887d523
Android build fails due to use of std::filesystem and
c++20 features like string::starts_with.
cmake requires c++2a flag
std::filesystem requires ndk 22+
Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: Ibba1e5e76a32ba5526d9d7111b810a650f372a02
- instead of using /dev/[u]random devices, use
getentropy() to make direct system calls
if the system is a BSD.
- if getentropy() fails, we need to fall back to
"/dev/[u]random" approach.
Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: Id6a2629c06d641eb4e7cf3991de4036d2f7b346e
problem:
before this patch innert textarea svg was not updated after changing text,
it was static based on first selection of textbox/shape,
to update the textarea we needed to unselect and reselect shape/textbox
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I11ceaf76867cecf5a356149d2072181e9f10b86e
<timar> net/clientnb.cpp:117:10: error: ‘shared_ptr’ in namespace ‘std’ does not name a template type
<timar> 117 | std::shared_ptr<WebSocket> getWebSocket()
<timar> | ^~~~~~~~~~
<timar> net/clientnb.cpp:38:1: note: ‘std::shared_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’?
IWYU agrees it's a missing include even if this builds for me by
accident.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I367ef3efcf2bdaf1b69c4bf21ef168e03807365c
When you are following someone and start typing, it's a pretty good
indication that you don't want to be following that person, particularly
because if they edit you will then be jumped over to where they are
We also need to stop unfollowAll from always rerendering the user list,
as when we rerendered on every keypress there was a noticable
performance degredation. Instead, we can make it only rerender when
we're following someone, which is a lot better.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I110ca74859b7cee03c6a58c87d3975275f29760d
so it will be also visible in notebookbar mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia311e3bff119b202b08b6ba04f75ad795d8a735c
in the past when JSON was generated from core it was needed...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I862bd405f17bd102d9772b0f806aec8bfcca4ac8
so we will check desktop only which can pass
This change should be reverted after we fix problems
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id34bf6446c7ea56fc8dd8ddf750abafd693c0aa1
It fails on triggerNewSVGForShapeInTheCenter()
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2693ea645a4103ecfd51db0405022764a0130d5a
Execute the 'prettier' command to check format code style.
Change-Id: I93e4a57e03d26627caa3b2c52ae44669a8723267
Signed-off-by: Henry Castro <hcastro@collabora.com>
The *.ts files in admin are transpiled typescript to *.js
so ignore the file to eslint again.
Change-Id: Icb5edbcc9d782562886c17453921979fd2dbdd2e
Signed-off-by: Henry Castro <hcastro@collabora.com>
cppunit-devel is not required for release build
nodejs is required, but may be provided by other means,
not by an rpm package.
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If761ef746559c9e002817f7a102191f5087001e2
- We specifically hide some section or elements in mobile view
- if we go level up or level down in mobile view, we should not change the state of those elements which already hidden using css rules
- this patch will cover that part of issue where we do not consider elements which are hidden by css rules
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I7ffd83c5b74987f74b7e327fd13775a81d02120d
- image path was wrongly assigned
- setImage method will do the work to set image path
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I765f0049d7d607926529df38a202b9ec923584b1
Useful to have a Unix socket-pair to communicate with
a forked process.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Ic4ad1eee62b6d3b40a03bc8e59bce6e0e16efc28
Seems browsers start to ping servers on their websockets, so don't
warn about that.
We trim memory left and right in clients, that doesn't deserve a
warning either.
Change-Id: I7bdcc99d167a8df3c847a1893dee8cd9123250f2
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Andras Timar
Gökay Şatır
Méven Car
Neil Guertin
Pranam Lashkari
Michael Meeks
Jaume Pujantell
Bayram Çiçek
Miklos Vajna
Skyler Grey
Szymon Kłos
Henry Castro
Darshan-upadhyay1110