Currently translated at 100.0% (587 of 587 strings)
Co-authored-by: Francisco Gabriel Chardin <fran@camba.coop>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I46f645bb20e021e4237b0153c4da2e321be9431d
Scroll to cell cursor after a part change. Relax the conditions.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I8c1aad11a00145b67e11afc2d11f9ebca0aa6feb
It seems there are two handler for this message.
Since we moved the authentication logic ahead
of the web-socket upgrade, the handler for
the unauthorized error doesn't display the
message. This fixes the it so now we correctly
display the unauthorized message.
Change-Id: Ic62476c74ce1583a2d7f33e1233e6fafd43d3bc4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Before this commit menu buttons were always generated with img even if
it's not applicable. Example, the StateTableCellMenu (located in Calc
status bar that allows setting a state according to the function
chosen in the submenu): This text-only menu was generated with img
and thus throwing a 404 error in the console.
- Allow any unoToolButton to be set without image via option
- Add image: false option when setting StateTableCellMenu in the
statusbar
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3fc3b5954f80229835526819b9b80d2a650bd922
This is a regression from commit 9923e69595
This is because jQuery .child() is only for the direct descendants.
Use .find() instead which will search down the DOM tree.
This restore postmessage Hide_Command / Hide_Button and Show.
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: Ibe84c520c9786c6c0026d3507a27a8d3580b38a0
Changed the menu entries to conform to the new format used by
JSDialog menu since 07da50a.
Signed-off-by: Jaume Pujantell <jaume.pujantell@collabora.com>
Change-Id: I69109675ec69d66eb25ae128a6bb102e4628c705
Currently translated at 60.2% (288 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 55.4% (265 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 55.2% (264 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 55.0% (263 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 53.7% (257 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (585 of 585 strings)
Translated using Weblate (Japanese)
Currently translated at 88.0% (515 of 585 strings)
Translated using Weblate (Japanese)
Currently translated at 88.0% (515 of 585 strings)
Translated using Weblate (Japanese)
Currently translated at 100.0% (22 of 22 strings)
Translated using Weblate (Japanese)
Currently translated at 68.1% (75 of 110 strings)
Translated using Weblate (Japanese)
Currently translated at 86.3% (19 of 22 strings)
Co-authored-by: Poe Mon <p.poemon.awitd@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-lib/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ja/
Translation: Collabora Online/Android app
Translation: Collabora Online/Android lib
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I6155250baf0d3f7ff2e54330cc9622a163ed177b
Currently translated at 100.0% (585 of 585 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (585 of 585 strings)
Co-authored-by: Sebastiaan Veld <sebastiaan.veld@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/nl/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I26404dbeefe0d28b080eb4dd9c480ef1a60ab9ff
Currently translated at 60.2% (288 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 55.2% (264 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 55.0% (263 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 53.7% (257 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 82.7% (484 of 585 strings)
Translated using Weblate (Japanese)
Currently translated at 38.0% (182 of 478 strings)
Translated using Weblate (Japanese)
Currently translated at 82.0% (480 of 585 strings)
Translated using Weblate (Japanese)
Currently translated at 78.9% (462 of 585 strings)
Co-authored-by: Shavazo <pleasure.7010@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ja/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ja/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I652016630fe632cb4815ce045596aabc4126b343
It is called when changes dark/light mode,
reset the fetch property to false.
Change-Id: Id8de5245d56405624ebe72b5655d37b52892f654
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change visual indicator before request a preview.
Change-Id: I3a050ebc2aa2216af9508e01f56a5bf46756f5e1
Signed-off-by: Henry Castro <hcastro@collabora.com>
While zooming, things like the cursor move along with the zoom. The
headers instead stayed fixed until the zoom is complete. This is
inconsistent with panning, and worsens your experience when zooming
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I100de8f1fd62b831c285c9acab456260dbb77ead
Similarly to I1a2060d44d3b75935bf138056330a52d56a028ae, I have made
panning past the document edge create an offset too. This provides
similar benefits to the fluidity of scrolling at document edges.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I2eedf2449620c5c8fec9ebf71dbe23d5a643ad5c
Zooming always leads to same backwards and forwards, even when you have
hit the screen edge. At the edge of the screen, you can move no further,
which causes the illusion of it being "sticky" on the return journey.
By adding an offset when we reach the edge, we can avoid the stickiness.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I1a2060d44d3b75935bf138056330a52d56a028ae
Remove createSection from CanvasSectionContainer.
Use extended classes.
Move some of the sections to their own files.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: If80e86f55920f80d9fb1fddef49ac451ed744b7c
typically can be seen on a fast connection to a NextCloud instance
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ie3431d58cb2499464e1bfac95dcf3b981536a7a2
To avoid the HTTP[S] request racing the websocket and sometimes
loosing we need to:
* get a notification from the Kit when the copy / cut is complete
* wait on a Promise for this, to allow the HTTP fetch to start
* re-work to do a single, rather than two fetches by sharing
the download promise.
Change-Id: Ic23f7f817cc855ff08f25a2afefcd73d6fc3472b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
It is required to initial preview place holder,
otherwise, there are some cases that the server takes
time to serve preview_placeholder.svg and it may cause
an ugly effect.
Change-Id: I70ac46c8c464b64a09f091cdf5f8644d208a79d4
Signed-off-by: Henry Castro <hcastro@collabora.com>
Change the cell selection circle color in dark mode.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I23826bdf0a09fa7e8b1c25132842f98e37997034
Since f7491e1f62 all combobox started
having a with and min-width of 100px, this wasn't meant to be.
Restrict this width setting to .jsDialog.
Add 5 px left padding to combobox, this looks better.
Set the font combobox width to 5em instead of 50px.
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I0f0247471376e4633f3bbffab89285e16f78cde9
Add CloseSession button.
Also improve spacing of elements.
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I9999654f9d53d44016eeb0ea587cf3f61b000471
Doesn't hide the grid when the Function wizard is open anymore
when disabling the ToggleSheetGrid button.
Depends on https://gerrit.libreoffice.org/c/core/+/167370
This is a follow up for issue #8066.
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I79ba99716eb1103e7239fe5cc302c64827c9ef53
So we front load at time of request as much work as possible when we are
basically idle rather than do it when the tiles arrive.
https://github.com/CollaboraOnline/online/issues/8744
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ief643f1e98cf4a853d56a68d82b48ff092e5a963
make the current uses that just pass the 1st argument explictly
set null for the 2nd arg and retain the orig lastRendered time
in that case.
This lastRendered gets overwritten by _tileReady after calling
_applyDelta.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I237d34e8d1fde94c95eb778c054e4ac5985c2a50
Sometimes an input we are focusing on is considered out of the viewport
by the browser. This is not always the case, and, even when it is, it's
not trivial to move it back in.
Instead, this change detects scrolling and re-scrolls the view to 0, 0.
Doing so is not without consequence, as there is a slight jitter before
we can scroll back, however this is substantially better than having the
controls off-the-page.
Signed-off-by: Skyler <skyler.grey@collabora.com>
Change-Id: Ie5003f9244ce1c0e8a183de5fdbcf3a880b13a13
It can be used to apply name to an object so it will
be presented in the navigator as something unique
Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: Ica06259dc3007d638a4998ccc2cce03ad1a5ca05
_applyDelta returns early if the initial "ensureContext" of the tile
fails.
i.e.
var ctx = this._ensureContext(tile);
if (!ctx) // out of canvas / texture memory.
return;
and ensureContext already calls ensureCanvas, so tile.canvas is
always true in the remainder of this function.
The "defer constructing the image & applying these deltas until the tile
is rendered via ensureCanvas." implied a sort of deliberate optimization
to wait until render time to apply the delta which doesn't actually
exist.
Also move the stray "// 'Uint8Array' delta" comment back to where it
originally came from as documentation of the type of the param, as in
commit 4140bf8741
Date: Sat Nov 6 11:11:13 2021 +0000
Bring back the delta application JS from the 6.4 branch.
...
_applyDelta: function(tile, delta) {
// 'Uint8Array' delta
...
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If15a897c3251f28639c9f1112687e543421e457d
It should always be visible when the function is called.
Rename the function to _setPreviewContainerTop for readability.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ib90da34574b0a5a44c9a2e7a2b2d64cdd2d59938
There is no need to add a visual break/divider between "Fullscreen
presentation" and the "Insert Slide" buttons:
1. They are visually very well distinctive so there seems to be not a
need for a division
2. There is not so much white space so the more we can reduce visually
the better
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I27b84782e5af987d9aec3734f7557c746a03667c
a problem since:
commit 04ac02b033
Date: Sun Sep 3 17:37:49 2023 +0300
Do not request tiles until we are sure a canonical id is set
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If285a53c51b17a812a7387150f99f0f43486b9e3
- when COOLWSD get SIGTERM admin sends a "shutdown_received" message to
indirection server
- indirection server sends back migration messages for each document to
migrate it other available COOL server
- there is timeout associated with migration message if COOLWSD doesn't
get message we move on and close the document
- added a new option in coolwsd.xml to change the migration timeout
default is 180s
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: Id7d5eea94d1b03ea5905ca67a9dd8f6ca15952f3
When export is disabled or watermarks are enabled, presentation in readonly mode
is disabled.
This is checked in the frontend by the WOPI property `DisablePresentation`
that is synthesized in the wsd. Also check when calling the presentation
command.
WOPIFileInfo::getWatermarkText() is stubbed on mobile.
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I4f7aff9f670f7523dfcf396f6009a272df9d5af8
Avoid the popup overlay and associated annoyance.
Also use a progress bar for loading in the normal overlay.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: Icafdcc958d92f42cba44e3b213d6a0202566251a
We need to get more helpful structure into this message, and add a
type=bg flag to handle background progress messages.
Add unit test for merging progress: setvalue commands.
Simplify ProtocolHandler sendTextMessage with a std::string wrapper.
Android code needs manual testing.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I54ce807e2fc5de80118905e68557a95e637fbd18
- Inherit padding from #formulabar desktop, a single dimension instead
of placing different margins/padding across mobile
- Fix alignments
- Use css vars for buttons sizes
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I21110e43115576a212d29b1a55268fbeed6d52af
- Remove individual sizes
- Rely on the same single size digit that comes from the parent
container
- AutomSum button should not inherit buttons height
- Fix jumping buttons: Cancelformula (close btn) should be placed
exactly where equal ("=") was before
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6c5a40709051ace3313195f4491798429eb5f6a0
Before this commit the buttons would jump position between default
button group and cell edit mode button group (when acceptformula and
cancelformula buttons appear)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5411f145a9f4f4d2dd10a4278105447a52755815
Better to rely on grid gap or somesuch
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I50e59d1b3464687a0bba76bf54a0ed2412dc3758
Make code more deterministic by removing old hacks with
timeout and cursor detection from:
- 6037d52
- b62320c
Bug was that on desktop when we were in formula edit mode
and we clicked cancel button - it was not showing again
the regular buttons but instead it was showing the
accept/cancel buttons.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1a51920e99f4902c1dbb62b0eab6e4f2edc932ce
this is shown after commit cf0a6f4
jsdialog: add "linkbutton" as an independent widget
it wasn't there before
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibdf8a9eb7f226740c11e8a34c16c7be4177576e6
To make consistent all toolbar element height with prev version where we were using w2Ui lib
- i have added height to table-row element same as we had in prev version
- remove fix height for toolbar-up which is not needed now
- this fix height will effect the bg-color in toolbar-up section
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I7b307a6a72968ed81fe2eb8663c430f11e3b3ced
Pedro :
This changes from flex to grid (so we can have multiple columns and 2 rows)
Darshan:
- adding one more div and wrap all child of toolbar-wrapper execpt 'formulabr' will work here
- i have tested the css grid approch it is breaking the mobile UI in Calc
- here i have changed a bit in html and twiked css which covers all cases
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia50fda95e2bef57d707bb4be1dd34e2ec083bfc5
With "Change table layout to CSS base table structure" and "Adjust
table elements for mobile view." changes we now have more divs instead
of table elements but with that the hamburger menu is now mislaigned
- Fix height
- To do: ideally we would make both hamburger menu and the button
at its side rendered with the exact same structure which is not the
case. And ultimately remove height and just have it flex stretch etc
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id9365df82f1caff132dde41760a06689ec1145d1
No need to specifically set width and height for .menuwizard-opened
state. Best to set only one time those dimensions and just inherit
from #toolbar-hamburger no matter the additional css class
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I51eafc6c9b05b843d800b40a990aefd912e463f8
- we changed table structure of `toolbar-wrapper` with `div`
- so we also need to consider mobile view
- made some neccessary changes for mobileview because of structure change in cool.html.m4 ('toolbar-wrapper')
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I91cd2c3ffbb0d625a78852398f6773136e9a7f6b
- For the editor in the home view, a layout table is used, and it includes the use of IDs. This can
potentially lead to issues with the interpretation of content by assistive technologies
- Layout tables are
meant to structure the layout of a page and should not contain structural markup like th , caption ,
summary , headers , or id.
Solution:
- replace `td` and 'table' tag with `div`
- make some changes on css to be consistent with our prev design
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I136cd8d51b2e5035c6ef4292f759f49519e5bd61
The _onScroll request the visible previews.
..
Change-Id: Ib5370f1790b489edb4626a22bf6c5bb1cd8d0f17
Signed-off-by: Henry Castro <hcastro@collabora.com>
It only initialize the initial preview width and height,
the _onScroll function will request the visible previews.
Change-Id: I7e04ea93f85a9270d09b241dc14391be214080a4
Signed-off-by: Henry Castro <hcastro@collabora.com>
This depends on the core change, which separates the linkbutton
widget from fixedtext widget as it is already an independent widget
in "weld" and used in accessibility checker. Adds "clicked" event
that is triggered when the text is clicked and send to the core.
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I4a999f3e57aaa7950482c55defa3012346351cb1
Enables the accessibility checker sidebar, changes the icons from
the old name to the new name (as it depends on the UNO name) and
adds the UNO command to enable the sidebar.
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: If9aeb375ec87ef27d4dead5f3148bc40f01db976
- Non-edit mode does not intialized after server reconnection
- this patch will fix initializedUI after reconnection
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I43405067287dd3f7f134fc9dcabfdcae183724ce
problem:
when try to edit any cell for the first time,
there was console error due to undefined variable
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8a29ad6e0e6243cc55175be0173eceb80bfea877
- Because we have appended '-input' to add ui-edit-control in jsDialog builder filer
- now we do not need any id/string which have '-input' at very end of that element
- for some cases we need correct GetElement by ID in js files
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id9b4f53e8deaa2f26c6abc93dc80504895107bd0
- To unify editControl, added additional "parent" for edit's input
- this will be consistent with other input type controls
- and will help to establish link between lable and input[type='edit']
- changed parameter from input to it's input container which will help to pass correct ID to Core
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: If5ab78bdf3d3ad61438898f5e4cacc19bd2ecb63
in 24.04 more elements are grid now, it seems to be a
regression in button box:
1. enable macro execution in coolwsd.xml
2. open spreadsheet with macro
Result: you see the dialog with buttons in 2 rows
Expected: all buttons are in the same row
it seems to be missing grid placement for left and right sections
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic1a3479114e4f832e852b9bdf3d39d2669ae69bb
problem:
when user selected disable macro in the opening dialog
document used to close and return to integrator
but now cancel button in csv import dialog is hidden,
so no need to distinguish there and we can continue to load without macros
In addition we still close the file if user clicks "X" button on title bar
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie0c7d77954e099cb3c8a72c400c688b3ae1343c7
Previously when there was a frozen pane we calculated an incorrect
size on the unfrozen pane, leading to slight blank edges when you were
mid-zoom-out.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Id26f6ba815429addd0cdf3af37f5c54363a08b2b
Previously when panning with zoom, the freeze shadow would stay in its
initial state (either hidden or shown) whether or not it should actually
be shown at the current position.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Ic0d05c1204b1e15abbb6d8ad34235206fdc7740c
Previously the freeze shadow would stay where it was, creating a hard
edge and confusion about where was frozen. With this change, the freeze
shadow moves with the zoom.
This change needs a followup to show/hide the shadow when we reach/move
away from the document edge.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I8bec41be6ce5eff3c1bfd3ac0234b6d53833614b
- Fix alignment between rows by:
- Setting some of the columns' width
- Removing margin from all buttons & set width. Add column gap
- Fix vertical alignment
- Fix header alignment (Name, Type, Value) so it aligns to the content
- Make "Add property" occupy full width (ideally this button would be
part of the inner grid "last row" but for now this is already an
improvement)
- Remove lengthly css targets and the use of nth-child
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I85d9bdbcc365c735757ee086f6e4912d694a011c
It sets a reply's status to "resolved" only if its parent is resolved.
I can't remember why we implemented this like this before.
But now, we don't need to.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia31dab0237d3b89e5d391cf87394514d18b595f7
Copy an image to the clipboard, click Paste -> Paste special on the
notebookbar in Firefox: the image is pasted, but the paste special
dialog doesn't close.
What happens here is that Firefox lacks navigator.clipboard.read(), so
the relevant code is Clipboard.js dataTransferToDocumentFallback(), not
the new _navigatorClipboardGetTypeCallback(). Here e.g. copy from
desktop Writer (html+text) would lead to a _doInternalPaste(), which
would call _checkAndDisablePasteSpecial() for us, but the image case
returns early, so the closing doesn't happen.
Fix the problem by explicitly calling _checkAndDisablePasteSpecial()
before returning early. In contrast with the other uses of
_checkAndDisablePasteSpecial(), we don't need to call the paste or paste
special uno command (since _asyncReadPasteImage() takes care of pasting
with a websocket comment), so it's fine to ignore the return value.
No testcase, our cypress tests run on Chrome, and this happens only with
Firefox.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I751d234edfdf9e8fb37f2bf2d6b3f3d8e65a27f4
insert shape now shows all the items in one column.
fix it so we have rows
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I371f7fa233e46a62dbb6637d934bc5ceb5cdecb0
problem:
when you try to reply to long comment, it would be resized
and subsequntly reply box will take space and other comments
will not make enough space for it
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4d81904721e5bb196947598d0dca211ee9d480a6
problem:
when comment was on the edge of the document/screen(vertically)
resize was called which ultimately collapsed the comments in small screen
which could not be expanded unless scrolled further from edge.
It was more problematic for the threads,
if entire thread could not fit in the screen it was always failing to expand
regression from bac4161
it nullifies the effect from 81b00e7
now if comment is added at the end of the document and it goes beyond doc boundry
doc will not scroll automatically to make entire comment visible
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I198b4887ae19ca0c17ba1453960cd36a66beb04d
problem:
when long thread did not fit on screen and actions were performed
on last comments of thread which put root comment out of view,
it will cause scroll back to root comment (i.e: reply)
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I23d699425dc2dff1cfeddf6ab9be7131f80c3a31
select function now can take care of reselection and layout update
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I2a061643ec190d5b2d005b940923a28131ed6cb0
lsy223622
Oğuz Ersen
Ali
Francisco Gabriel Chardin
Matthaiks
Andras Timar
Gökay Şatır
Hubert Figuière
Ashod Nakashian
Rashesh Padia
Pedro Pinto Silva
Jaume Pujantell
Poe Mon
bittin1ddc447d824349b2
Rob Pearson
Shavazo
Alexander Gabilondo
Sebastiaan Veld
Milo Ivir
SC
Henry Castro
Skyler Grey
Caolán McNamara
Michael Meeks
Méven Car
Bayram Çiçek
Szymon Kłos
Gülşah Köse
NickWingate
Darshan-upadhyay1110
Tomaž Vajngerl
Pranam Lashkari
Julius Härtl
Miklos Vajna
Aron Budea
Gökay Şatır