Commit Graph

3088 Commits (ff711e60b2b71e3f33e150fdff1d2d0de6cbc3ee)

Author SHA1 Message Date
Ludovic Marcotte 00777fa7f3 (fix) respect the LDAP attributes mapping in the list view 2016-03-18 12:38:47 -04:00
Ludovic Marcotte 9d6ab2df33 (feat) user rate-limiting support for all SOGo requests 2016-03-18 11:04:41 -04:00
Ludovic Marcotte e7b0119ab1 (fix) don't skip last identity 2016-03-14 13:18:56 -04:00
Francis Lachapelle 08a94fa539 Add Lithuanian translation 2016-03-14 10:08:25 -04:00
Ludovic Marcotte 9a4d2c6b1c (fix) properly null-terminate IS8601-formatted dates (fixes #3539) 2016-03-13 14:25:09 -04:00
Ludovic Marcotte beb4af9f9f (fix) avoid compilation warning from previous commit 2016-03-13 13:45:58 -04:00
Ludovic Marcotte 85cacd97de Use GMT tz when setting birthday (fixes #3579) 2016-03-13 13:44:42 -04:00
Ludovic Marcotte 4ac41dace7 (core) new database structure options to make SOGo use a total of nine tables 2016-03-10 16:34:06 -05:00
Francis Lachapelle 9d5de9afb7 Merge pull request #201 from inverse-inc/warning-removal-again
Warning removal, next part.
2016-03-09 15:59:11 -05:00
Ludovic Marcotte 4026c4e2d9 (fix) more attendee checks 2016-03-09 10:06:18 -05:00
Ludovic Marcotte bd81a56e58 (fix) make sure the attendee name is defined before using it 2016-03-08 10:41:49 -05:00
Ludovic Marcotte 81daade9ec (fix) remove unnecessary error message 2016-03-08 08:24:16 -05:00
Francis Lachapelle 255e21795e Update translations 2016-03-07 10:59:54 -05:00
Patrice Levesque c3f69416be Replace stubs with parent implementations.
Which makes real sense; reference from
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880038 and
https://github.com/inverse-inc/sogo/pull/201#discussion_r54880094
2016-03-07 10:46:40 -05:00
Patrice Levesque 4210131e12 Initialize highestmodseq to avoid any surprise.
Strongly inspired by comment at https://github.com/inverse-inc/sogo/pull/201#discussion-diff-54879796
2016-03-07 10:43:38 -05:00
Patrice Levesque ce38a9c606 Fix one warning: expected ‘struct NSError **’ but argument is of type ‘id’
nil is not recognized by GCC as a (NSError**), but as an (id).  NULL works the
same but does not spawn warnings.
2016-03-07 10:34:41 -05:00
Patrice Levesque a813e38897 Comment out sendMail method in SOGoDraftObject and replace its sole known usage by sendMailAndCopyToSent.
In a 2011-09-26 commit (in Changelog.old), I understand the author wanted to
phase sendMail out and replace it by sendMailAndCopyToSent.  Since there are
compilation warnings related to sendMail, removing the sendMail method and
replacing the sole call to it seemed like the cleanest way.
2016-03-07 10:34:41 -05:00
Patrice Levesque 281062a1a1 Fix warning: incomplete implementation of category ‘SOGoExtensions’
Original method was commented out, but not its matching .h declaration;
hence commenting out the .h declaration.
2016-03-07 10:34:41 -05:00
Patrice Levesque c1095a5ea9 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
As previous commit, this code assumed pointers are unsigned int, for display
purpose.  Replaced the cast with the native '%p' token from
NSMutableString::appendFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque 022fd81474 Fix warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
Those are all log formatting routines that assume pointers are unsigned int,
for display purpose.  Replace the cast with the native '%p' token from
NSString::stringWithFormat that's provided for pointer address output.
2016-03-07 10:34:41 -05:00
Patrice Levesque 478b313122 Fix warning: distinct Objective-C type in return
Method is supposed to return a WOResponse pointer, but currently returns a
NSException pointer; typecast the return value, just like the archiveUIDs
method does.
2016-03-07 10:34:41 -05:00
Patrice Levesque 3ba0e9f82f Implement stubs for SOGoCalendarComponent::isNew and SOGoCalendarComponent::setIsNew methods.
Those are required to implement the SOGoComponentOccurence protocol hence
their absence creates compilation warnings.
2016-03-07 10:34:40 -05:00
Patrice Levesque 0b1cf9faaf Avoid warning: the address of ‘timezone’ will always evaluate as ‘true’
As timezone is a pointer allocated on the stack, there is no need to check
for a NULL pointer - if that was ever the initial intention.
2016-03-07 10:34:40 -05:00
Patrice Levesque 5b71ed319a Fix warning: variable ‘uidnext’ set but not used [-Wunused-but-set-variable]
Remove uidnext declaration and calls that change its value.
2016-03-07 10:34:40 -05:00
Patrice Levesque ddade629fd Synchronize .h and .m method signatures. 2016-03-07 10:34:40 -05:00
Patrice Levesque 5e9d0ce95a Fix warning: ‘-textValue’ not found in protocol(s)
Confusingly, labelNode is a DOMElement, not a DOMNode, so textValue cannot
apply here; textContent which would be an appropriate replacement does not
exist AFAIK in this DOM Library.

So we manually get the text node via firstChild then get its text value
via nodeValue.
2016-03-07 10:34:40 -05:00
Francis Lachapelle eefb9056ca (html) Use datepicker for task completion date 2016-03-04 11:34:02 -05:00
Francis Lachapelle b808067cf7 Keep specified task status when not completed
Fixes #3499
2016-03-04 10:24:12 -05:00
Francis Lachapelle 3529d52c3b Fix extraction of mail column from SQL source
Fixes #3544
2016-02-29 11:56:32 -05:00
Francis Lachapelle a668d89ef9 Fix unseen count retrieval of nested IMAP folders 2016-02-26 14:59:54 -05:00
Francis Lachapelle 07d47829ab Fix default priority of sent messages
Fixes #3542
2016-02-25 11:53:34 -05:00
Francis Lachapelle 5387b5d5a3 Expose listRequiresDot in SOGoContactSourceFolder 2016-02-24 16:47:07 -05:00
Francis Lachapelle 4030cf86fd (feature) Live loading of (GCS) addressbooks
Using md-on-demand of md-virtual-repeat, we now progressively load the
cards metadata of a personal addressbook.
2016-02-19 23:19:07 -05:00
Francis Lachapelle 21dcb57ca9 Remove unrelevent #warning 2016-02-19 16:28:43 -05:00
Francis Lachapelle 485a9d4462 Fix import of cn from SQL source 2016-02-19 16:09:08 -05:00
Patrice Levesque 9cb1b899b0 Merge branch 'master' into fix-some-warnings
Conflicts:
	UI/Scheduler/UIxAppointmentActions.m
2016-02-16 14:32:50 -05:00
Francis Lachapelle 4c01417690 Handle resource limits in the Web interface
See @d7b010
2016-02-16 12:40:59 -05:00
Francis Lachapelle d56d9f8b08 Handle attendee conflicts in the Web interface
See @d7b010
2016-02-15 16:03:16 -05:00
Patrice Levesque a5cc2bb5d5 Merge branch 'master' into fix-some-warnings
Conflicts:
	SoObjects/Appointments/SOGoAppointmentObject.m
2016-02-15 11:23:27 -05:00
Patrice Levesque 9e83ff9f04 Fix compilation errors with OpenSSL 2016-02-15 11:14:06 -05:00
Patrice Levesque bd56f4cf9f Remove pointless #include from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 17:41:54 -05:00
Patrice Levesque 7c25b53fdf Remove pointless #imports from .m and .h files
This was done with a brute-force approach, ensuring no additional
warnings from GCC 4.9 under x86_64.
2016-02-13 16:11:52 -05:00
Ludovic Marcotte 132234cc19 (fix) don't consider default ACLs for attendees 2016-02-12 14:40:51 -05:00
Francis Lachapelle 256a64172e (feature) Custom base font size for HTML messages
If SOGoMailComposeFontSize is set to zero, we keep the previous
behaviour (no font-size added to the message HTML body).
2016-02-11 17:45:57 -05:00
Ludovic Marcotte d7b010526b (feat) warn when double-booking attendees and offer force save option 2016-02-11 10:54:07 -05:00
Francis Lachapelle 99e5c1b93c (feature) Convert a message to an event or task
Resolves #1722
2016-02-10 16:15:00 -05:00
Patrice Levesque 93158f5121 Wrap common looping idiom inside double-parenthesis to shutup warning 2016-02-10 15:16:42 -05:00
Ludovic Marcotte 8c99fdc99a (fix) allow resources to prevent invitations (fixes #3410) 2016-02-10 15:03:20 -05:00
Patrice Levesque 296d510572 Merge branch 'missing-prototypes' into fix-some-warnings
Avoid compilation errors when using GCC with -Werror=missing-declarations
and -Werror=missing-prototypes (those flags are wanted to track and fix
further warnings).
2016-02-10 14:58:28 -05:00
Patrice Levesque 51cbb980ad Add some missing preprocessing #import directives
Fixes most GCC warnings of form:
	warning: @interface of class ‘MyClass’ not found
2016-02-10 14:46:11 -05:00
Ludovic Marcotte 693f80dc9a (feat) now supports RFC6154 and NoInferiors IMAP flag 2016-02-10 10:00:59 -05:00
Patrice Levesque 5539b7a823 Add missing header prototypes
Fixes compiling errors with GCC using -Werror=missing-prototypes.
2016-02-08 16:14:33 -05:00
Ludovic Marcotte ee3276f01d (feat) added Junk handling feature from v2 2016-02-08 15:36:01 -05:00
Ludovic Marcotte d3f59ba621 (fix) add shared/public namespaces in the list or returned folders 2016-02-05 10:01:18 -05:00
Francis Lachapelle d4ab5dd21b Update translations 2016-02-04 14:01:31 -05:00
Francis Lachapelle a8845d262f Fix frequency detection of recurrence rule 2016-02-04 09:20:11 -05:00
Francis Lachapelle bd4f42b948 Fix comparisons with NSNotFound
Fixes #3472
2016-02-03 13:54:08 -05:00
Francis Lachapelle 5a927dfeb3 Improve formatting of SOGoDefaults.plist 2016-01-27 11:27:30 -05:00
Francis Lachapelle b265de91fd Add Croatian translation 2016-01-25 11:14:45 -05:00
ethoms 99765aae53 fix (revised) for issue with CardDAV sync with the DAVDroid sync client.
This is a revised fix for the issue raiased in sogo bug tracker 3370 and 3373. It supercedes the fix in commit  2c723070c6 .

The fix was noted in NEWS with the comment "we now return all cards when we receive an empty addressbook-query REPORT". However it did not work for me and at least two others, as can be seen in the commit comments. In summary, only contacts with email addresses were synced. The suggested change from kwirk fixes the regular address book sync, but it completely breaks syncing of the read-only Group Directory (Corporate Directory). My suggested changes work in full (as far as I'm able to test).

I have done some fairly extensive testing of CardDAV sync (with DAVDroid only) and it seems to work 100% now. In addition to the obvious tests, I have tested with contacts that only have one field of data entered. The feilds I've tested (with all other fields empty) are as follows:

First name
Last name
Display name
email address
Work (telephone)
Home (telephone)
Fax (telephone)
Mobile (telephone)

Additionally, I tested syncing of a contact with only the Work Address fully populated. In the webmail, since the name fields are all missing, the "Organization" field of the Work Address takes the place of the name field in the 'Name' column. This does get synced to my phone and it also appears my Android contact list with 'Name' set to the 'Organization' field data. The address, organization and website fields being in tact also.

In addition, I tested a Group Directory (Corporate Directory) [SOGoUserSources->isAddressBook] sync. It seems contacts without email addresses do not sync. This seems to be the behaviour across the board with a "." search filter. This happens despite the filter in SOGoUserSources including ldap entries without a mail attribute. Nothing I can do to patch this in SOGoFolder+CardDAV.m, that would have to be fixed in the code that deals with the special "." search filter (I guess).

I think the contact search system needs some looking into, particularly the "." search filter behaviour. There is another bug related to contact search in the webmail address book view. I will make a bug report on that soon. It's a shame there isn't an "all" search filter, it would seem it would make various parts of SOGo easier to get the right behaviour.
2016-01-25 09:19:41 -05:00
Ludovic Marcotte 3c0059192d (fix) rewrote the string sanitization to be 32-bit Unicode safe 2016-01-22 20:31:55 -05:00
Ludovic Marcotte 30377c0fd6 (feat) new junk/not junk capability with generic SMTP integration
Conflicts:

	NEWS
	SoObjects/Mailer/SOGoMailAccount.m
	SoObjects/SOGo/SOGoDefaults.plist
	SoObjects/SOGo/SOGoUser.m
	UI/MailerUI/UIxMailFolderActions.h
	UI/MailerUI/UIxMailFolderActions.m
	UI/MailerUI/product.plist
2016-01-22 13:58:45 -05:00
Francis Lachapelle 8076a1a7ef Update translations 2016-01-21 10:17:36 -05:00
Ludovic Marcotte b3bc6bb7dc Applied changes coming from v2/PR#184. 2016-01-18 09:26:07 -05:00
Ludovic Marcotte 0b5e38e88c (fix) we now follow 301 redirects when fetching ICS calendars 2016-01-08 13:13:35 -05:00
Ludovic Marcotte 4935eb23a9 (fix) Fixed DomainLessLogin logins in multi-domain 2016-01-08 11:40:02 -05:00
Ludovic Marcotte 6ffeba59ed (feat) Now able to sync only default mail folders when using EAS
Conflicts:

	NEWS
	SoObjects/SOGo/SOGoUserDefaults.h
	SoObjects/SOGo/SOGoUserDefaults.m
2016-01-07 09:19:44 -05:00
Francis Lachapelle c65a9155be Improve verification of SOGoLoginDomains array 2016-01-06 09:53:18 -05:00
Ludovic Marcotte ae6ed0c055 (feat) applied all changes as a patch coming from PR #180 2015-12-30 09:22:08 -05:00
Francis Lachapelle 711e159b4b Properly compute the last week number for the year
Fixes #1010
2015-12-22 14:19:02 -05:00
Ludovic Marcotte 3404ae8105 (fix) carry over delegatedFrom too 2015-12-15 16:28:58 -05:00
Ludovic Marcotte 76f0ec9ae0 (fix) carry over the delegatedTo, not only the part stat 2015-12-15 16:28:13 -05:00
Ludovic Marcotte 0f578876af (fix) small fix over previous commit 2015-12-15 11:15:28 -05:00
Ludovic Marcotte cfb741fc9f (fix) avoid duplicating attendees when accepting event using a different identity over CalDAV
Conflicts:

	SoObjects/Appointments/iCalEntityObject+SOGo.h
2015-12-15 11:12:59 -05:00
Francis Lachapelle 544cb85e4d Localization 2015-12-15 10:05:46 -05:00
Francis Lachapelle ffe4d0f232 Localization 2015-12-15 09:56:52 -05:00
Ludovic Marcotte 0b10e20d37 (fix #127) fallback to "work" when export as ldif 2015-12-11 14:50:26 -05:00
Ludovic Marcotte 9b5d37ff3d (fix) added missing languages to the plist 2015-12-04 13:52:10 -05:00
Ludovic Marcotte e80c7da188 (fix) add the languages to the classes too 2015-12-04 13:49:11 -05:00
Ludovic Marcotte b4aa8b27d4 (fix) added Macedonian and Portuguese to the GNUmakefile files 2015-12-04 13:43:36 -05:00
Ludovic Marcotte 3cd973b365 (fix) added missing files for Macedonian and Portuguese translations 2015-12-04 13:03:11 -05:00
Ludovic Marcotte c427a62fb0 (fix) sync'ed translations with files from v2 2015-12-04 12:48:52 -05:00
Ludovic Marcotte 9b0a2c5fae Merge branch 'master' into feature/addMissingStrings2
Conflicts:
	UI/AdministrationUI/English.lproj/Localizable.strings
	UI/PreferencesUI/English.lproj/Localizable.strings
	UI/Templates/PreferencesUI/UIxFilterEditor.wox
2015-12-03 11:16:17 -05:00
Ludovic Marcotte 0660db7bf6 (fix) reverted change for #3389 2015-12-01 11:41:18 -05:00
Ludovic Marcotte d51d5c85b0 (fix) prevent characters in calendar component UID causing issues during import process 2015-12-01 09:27:27 -05:00
Ludovic Marcotte 403d6fa54f (feat) you can now select your alternate avatar 2015-11-27 16:04:12 -05:00
Ludovic Marcotte fc16d6ad90 (fix) fixed addressbrook-only source entires having a c_uid set
Conflicts:

	NEWS
	SoObjects/Contacts/SOGoContactSourceFolder.m
2015-11-06 13:38:26 -05:00
Ludovic Marcotte 0d919dbd02 (fix) small fixes 2015-11-06 09:02:06 -05:00
Ludovic Marcotte ab322093cd (fix) handle emails having an attachment as their content 2015-11-05 15:21:33 -05:00
Francis Lachapelle f3f7ca8599 Merge pull request #115 from ethoms/clang-warnings-stage8
Stage 8 of clang compiler warning patches.
2015-11-05 13:22:08 -05:00
ethoms 3a103fd0dd Update WORequest+SOGo.m 2015-11-06 01:47:32 +08:00
Ludovic Marcotte a8525658b3 (fix) additional fix for #3118 2015-11-05 11:11:49 -05:00
Ludovic Marcotte 5f82d3fb37 (fix) manually added fixes from PR#120 2015-11-05 09:59:31 -05:00
extrafu 9fb69a8095 Merge pull request #113 from ethoms/clang-warnings-stage6
Stage 6 of clang compiler warning patches.
2015-11-05 09:34:24 -05:00
ethoms bf87c71671 Update WORequest+SOGo.m 2015-11-05 10:23:01 +08:00
ethoms 30488f4f6d Update WORequest+SOGo.m 2015-11-05 10:22:11 +08:00
ethoms 4ca3a1f42d Update SOGoParentFolder.m 2015-11-05 08:01:38 +08:00
ethoms efbf8825b1 Update SOGoParentFolder.m 2015-11-05 07:29:45 +08:00
ethoms becfdc215f Update SOGoParentFolder.h 2015-11-05 07:20:36 +08:00
extrafu d805cdfef4 Merge pull request #109 from ethoms/clang-warnings-stage2
Stage 2 of clang compiler warning patches.
2015-11-04 13:48:27 -05:00