LupusNobilis
/
sogo
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
13,377 Commits
12 Branches
116 Tags
168 MiB
Commit Graph

3088 Commits (ff711e60b2b71e3f33e150fdff1d2d0de6cbc3ee)

Author SHA1 Message Date
Ludovic Marcotte 693f80dc9a (feat) now supports RFC6154 and NoInferiors IMAP flag 2016-02-10 10:00:59 -05:00
Patrice Levesque 5539b7a823 Add missing header prototypes 
Fixes compiling errors with GCC using -Werror=missing-prototypes.
 2016-02-08 16:14:33 -05:00
Ludovic Marcotte ee3276f01d (feat) added Junk handling feature from v2 2016-02-08 15:36:01 -05:00
Ludovic Marcotte d3f59ba621 (fix) add shared/public namespaces in the list or returned folders 2016-02-05 10:01:18 -05:00
Francis Lachapelle d4ab5dd21b Update translations 2016-02-04 14:01:31 -05:00
Francis Lachapelle a8845d262f Fix frequency detection of recurrence rule 2016-02-04 09:20:11 -05:00
Francis Lachapelle bd4f42b948 Fix comparisons with NSNotFound 
Fixes #3472
 2016-02-03 13:54:08 -05:00
Francis Lachapelle 5a927dfeb3 Improve formatting of SOGoDefaults.plist 2016-01-27 11:27:30 -05:00
Francis Lachapelle b265de91fd Add Croatian translation 2016-01-25 11:14:45 -05:00
ethoms 99765aae53 fix (revised) for issue with CardDAV sync with the DAVDroid sync client. 
This is a revised fix for the issue raiased in sogo bug tracker 3370 and 3373. It supercedes the fix in commit  2c723070c6 .

The fix was noted in NEWS with the comment "we now return all cards when we receive an empty addressbook-query REPORT". However it did not work for me and at least two others, as can be seen in the commit comments. In summary, only contacts with email addresses were synced. The suggested change from kwirk fixes the regular address book sync, but it completely breaks syncing of the read-only Group Directory (Corporate Directory). My suggested changes work in full (as far as I'm able to test).

I have done some fairly extensive testing of CardDAV sync (with DAVDroid only) and it seems to work 100% now. In addition to the obvious tests, I have tested with contacts that only have one field of data entered. The feilds I've tested (with all other fields empty) are as follows:

First name
Last name
Display name
email address
Work (telephone)
Home (telephone)
Fax (telephone)
Mobile (telephone)

Additionally, I tested syncing of a contact with only the Work Address fully populated. In the webmail, since the name fields are all missing, the "Organization" field of the Work Address takes the place of the name field in the 'Name' column. This does get synced to my phone and it also appears my Android contact list with 'Name' set to the 'Organization' field data. The address, organization and website fields being in tact also.

In addition, I tested a Group Directory (Corporate Directory) [SOGoUserSources->isAddressBook] sync. It seems contacts without email addresses do not sync. This seems to be the behaviour across the board with a "." search filter. This happens despite the filter in SOGoUserSources including ldap entries without a mail attribute. Nothing I can do to patch this in SOGoFolder+CardDAV.m, that would have to be fixed in the code that deals with the special "." search filter (I guess).

I think the contact search system needs some looking into, particularly the "." search filter behaviour. There is another bug related to contact search in the webmail address book view. I will make a bug report on that soon. It's a shame there isn't an "all" search filter, it would seem it would make various parts of SOGo easier to get the right behaviour.
 2016-01-25 09:19:41 -05:00
Ludovic Marcotte 3c0059192d (fix) rewrote the string sanitization to be 32-bit Unicode safe 2016-01-22 20:31:55 -05:00
Ludovic Marcotte 30377c0fd6 (feat) new junk/not junk capability with generic SMTP integration 
Conflicts:

	NEWS
	SoObjects/Mailer/SOGoMailAccount.m
	SoObjects/SOGo/SOGoDefaults.plist
	SoObjects/SOGo/SOGoUser.m
	UI/MailerUI/UIxMailFolderActions.h
	UI/MailerUI/UIxMailFolderActions.m
	UI/MailerUI/product.plist
 2016-01-22 13:58:45 -05:00
Francis Lachapelle 8076a1a7ef Update translations 2016-01-21 10:17:36 -05:00
Ludovic Marcotte b3bc6bb7dc Applied changes coming from v2/PR#184. 2016-01-18 09:26:07 -05:00
Ludovic Marcotte 0b5e38e88c (fix) we now follow 301 redirects when fetching ICS calendars 2016-01-08 13:13:35 -05:00
Ludovic Marcotte 4935eb23a9 (fix) Fixed DomainLessLogin logins in multi-domain 2016-01-08 11:40:02 -05:00
Ludovic Marcotte 6ffeba59ed (feat) Now able to sync only default mail folders when using EAS 
Conflicts:

	NEWS
	SoObjects/SOGo/SOGoUserDefaults.h
	SoObjects/SOGo/SOGoUserDefaults.m
 2016-01-07 09:19:44 -05:00
Francis Lachapelle c65a9155be Improve verification of SOGoLoginDomains array 2016-01-06 09:53:18 -05:00
Ludovic Marcotte ae6ed0c055 (feat) applied all changes as a patch coming from PR #180 2015-12-30 09:22:08 -05:00
Francis Lachapelle 711e159b4b Properly compute the last week number for the year 
Fixes #1010
 2015-12-22 14:19:02 -05:00
Ludovic Marcotte 3404ae8105 (fix) carry over delegatedFrom too 2015-12-15 16:28:58 -05:00
Ludovic Marcotte 76f0ec9ae0 (fix) carry over the delegatedTo, not only the part stat 2015-12-15 16:28:13 -05:00
Ludovic Marcotte 0f578876af (fix) small fix over previous commit 2015-12-15 11:15:28 -05:00
Ludovic Marcotte cfb741fc9f (fix) avoid duplicating attendees when accepting event using a different identity over CalDAV 
Conflicts:

	SoObjects/Appointments/iCalEntityObject+SOGo.h
 2015-12-15 11:12:59 -05:00
Francis Lachapelle 544cb85e4d Localization 2015-12-15 10:05:46 -05:00
Francis Lachapelle ffe4d0f232 Localization 2015-12-15 09:56:52 -05:00
Ludovic Marcotte 0b10e20d37 (fix #127) fallback to "work" when export as ldif 2015-12-11 14:50:26 -05:00
Ludovic Marcotte 9b5d37ff3d (fix) added missing languages to the plist 2015-12-04 13:52:10 -05:00
Ludovic Marcotte e80c7da188 (fix) add the languages to the classes too 2015-12-04 13:49:11 -05:00
Ludovic Marcotte b4aa8b27d4 (fix) added Macedonian and Portuguese to the GNUmakefile files 2015-12-04 13:43:36 -05:00
Ludovic Marcotte 3cd973b365 (fix) added missing files for Macedonian and Portuguese translations 2015-12-04 13:03:11 -05:00
Ludovic Marcotte c427a62fb0 (fix) sync'ed translations with files from v2 2015-12-04 12:48:52 -05:00
Ludovic Marcotte 9b0a2c5fae Merge branch 'master' into feature/addMissingStrings2 
Conflicts:
	UI/AdministrationUI/English.lproj/Localizable.strings
	UI/PreferencesUI/English.lproj/Localizable.strings
	UI/Templates/PreferencesUI/UIxFilterEditor.wox
 2015-12-03 11:16:17 -05:00
Ludovic Marcotte 0660db7bf6 (fix) reverted change for #3389 2015-12-01 11:41:18 -05:00
Ludovic Marcotte d51d5c85b0 (fix) prevent characters in calendar component UID causing issues during import process 2015-12-01 09:27:27 -05:00
Ludovic Marcotte 403d6fa54f (feat) you can now select your alternate avatar 2015-11-27 16:04:12 -05:00
Ludovic Marcotte fc16d6ad90 (fix) fixed addressbrook-only source entires having a c_uid set 
Conflicts:

	NEWS
	SoObjects/Contacts/SOGoContactSourceFolder.m
 2015-11-06 13:38:26 -05:00
Ludovic Marcotte 0d919dbd02 (fix) small fixes 2015-11-06 09:02:06 -05:00
Ludovic Marcotte ab322093cd (fix) handle emails having an attachment as their content 2015-11-05 15:21:33 -05:00
Francis Lachapelle f3f7ca8599 Merge pull request #115 from ethoms/clang-warnings-stage8 
Stage 8 of clang compiler warning patches.
 2015-11-05 13:22:08 -05:00
ethoms 3a103fd0dd Update WORequest+SOGo.m 2015-11-06 01:47:32 +08:00
Ludovic Marcotte a8525658b3 (fix) additional fix for #3118 2015-11-05 11:11:49 -05:00
Ludovic Marcotte 5f82d3fb37 (fix) manually added fixes from PR#120 2015-11-05 09:59:31 -05:00
extrafu 9fb69a8095 Merge pull request #113 from ethoms/clang-warnings-stage6 
Stage 6 of clang compiler warning patches.
 2015-11-05 09:34:24 -05:00
ethoms bf87c71671 Update WORequest+SOGo.m 2015-11-05 10:23:01 +08:00
ethoms 30488f4f6d Update WORequest+SOGo.m 2015-11-05 10:22:11 +08:00
ethoms 4ca3a1f42d Update SOGoParentFolder.m 2015-11-05 08:01:38 +08:00
ethoms efbf8825b1 Update SOGoParentFolder.m 2015-11-05 07:29:45 +08:00
ethoms becfdc215f Update SOGoParentFolder.h 2015-11-05 07:20:36 +08:00
extrafu d805cdfef4 Merge pull request #109 from ethoms/clang-warnings-stage2 
Stage 2 of clang compiler warning patches.
 2015-11-04 13:48:27 -05:00
extrafu cc1555af22 Merge pull request #108 from ethoms/clang-warnings-stage1 
Stage1 of clang compiler warning patches.
 2015-11-04 13:40:09 -05:00
Ludovic Marcotte 39601a9cf9 (feat) moved FolderSynchronize code to GCS 
Conflicts:

	SoObjects/Appointments/SOGoAppointmentFolder.h
 2015-11-04 09:55:02 -05:00
ethoms 0cb1504f2c Update SOGoCalendarComponent.m 2015-11-04 08:18:23 +08:00
ethoms 6dc912eee5 Update SOGoGCSFolder.m 2015-11-04 07:29:50 +08:00
ethoms 1a0915ebf6 Update SOGoFolder.m 2015-11-04 07:27:53 +08:00
ethoms 6bff05b84a Update SOGoMailLabel.m 2015-11-04 07:24:02 +08:00
ethoms b5eb13c3b7 Update SOGoContactSourceFolder.m 2015-11-04 07:19:37 +08:00
extrafu 1fab2028e2 Merge pull request #116 from ethoms/clang-warnings-stage9 
Stage 9 of clang compiler warning patches.
 2015-11-03 18:08:28 -05:00
extrafu b7ebf6e781 Merge pull request #112 from ethoms/clang-warnings-stage5 
Stage 5 of clang compiler warning patches.
 2015-11-03 18:06:33 -05:00
extrafu d9a929762f Merge pull request #111 from ethoms/clang-warnings-stage4 
Stage 4 of clang compiler warning patches.
 2015-11-03 18:02:48 -05:00
extrafu 165337bebc Merge pull request #110 from ethoms/clang-warnings-stage3 
Stage 3 of clang compiler warning patches.
 2015-11-03 18:01:04 -05:00
Euan Thoms 46ccd04c70 Stage 9 of clang compiler warning patches. 2015-11-04 06:13:01 +08:00
Euan Thoms 440a86d3f2 Stage 8 of clang compiler warning patches. 2015-11-04 06:02:45 +08:00
Euan Thoms 0b4c355c2c Stage 6 of clang compiler warning patches. 2015-11-04 05:37:39 +08:00
Euan Thoms 36c1ba88a5 Stage 5 of clang compiler warning patches. 2015-11-04 05:28:03 +08:00
Euan Thoms 2303a250c5 Stage 4 of clang compiler warning patches. 2015-11-04 04:59:27 +08:00
Francis Lachapelle cbf9b6da3e Fix all-day events covering a timezone change 2015-11-03 15:47:30 -05:00
Euan Thoms a64d55f95c Stage 3 of clang compiler warning patches. 2015-11-04 03:59:40 +08:00
Euan Thoms 9a3f8549ea Delete .orig files left over from applying patches to Stage 2. 2015-11-04 03:40:53 +08:00
Euan Thoms 212ff64828 Stage 2 of clang compiler warning patches. 2015-11-04 03:36:34 +08:00
Euan Thoms 3c62cc744e Stage 1 of clang compiler warning patches. 2015-10-31 14:10:03 +08:00
Ludovic Marcotte 987700cd87 (fix) inline images sent from SOGo webmail are not displayed in Mozilla Thunderbird (#3271) 2015-10-23 14:35:10 -04:00
Ludovic Marcotte a55d5c95b5 (fix) avoid crash when replying to a mail with no recipients (#3359) 2015-10-23 12:45:28 -04:00
Ludovic Marcotte 907c30061f (fix) we now return all cards when we receive an empty addressbook-query REPORT 2015-10-21 10:55:09 -04:00
Ludovic Marcotte 020fa78848 (feat) initial S/MIME support for EAS (#3327) 2015-10-15 15:32:15 -04:00
Ludovic Marcotte bfa3cf379c (fix) numerous EAS fixes when connections are dropped before the EAS client receives the response (#3058, #2849) 
Conflicts:

	NEWS
 2015-10-14 09:23:03 -04:00
Juan Vallés 0982d50643 Improve first character check in CSS identifiers 
A CSS identifier can't start with a digit, so when a folder name does,
a '_' character is appended at the beginning of its CSS identifier.

The check for this first character used the `isdigit()` function, which
takes a `char` argument, while `[self objectAtIndex: 0]` returns a
`unichar`, i.e. a 16-bit unsigned integer. This caused some non-digit
characters to pass this check (e.g. Chinese characters), ending up with
an underscore at the beginning of the folder name.
 2015-09-14 12:55:32 -04:00
Ludovic Marcotte 6bbd182559 (fix) safe-guard against not-yet-created calendar of local users 2015-09-10 20:08:48 -04:00
Ludovic Marcotte 788f36b96e (fix) slight modification for fix #3293 2015-09-10 19:11:37 -04:00
Ludovic Marcotte 59ad8a2e5a (fix) improved EAS speed during initial syncing of large mailboxes (#3293) 
Conflicts:

	SoObjects/Mailer/SOGoMailFolder.h
	SoObjects/SOGo/SOGoGCSFolder.m
 2015-09-09 10:22:29 -04:00
Ludovic Marcotte b3d6973fb1 (fix) small optimization 2015-08-26 09:31:08 -04:00
Luc Charland 9445315b30 Added a string, removed a double, removed a few colons 2015-08-25 11:11:46 -04:00
Ludovic Marcotte b80d8dbb06 (fix) Session fix when SOGoEnableDomainBasedUID is enabled but logins are domain-less 2015-08-21 10:51:45 -04:00
Ludovic Marcotte 161bcfac87 (fix) proper loading of transalations 2015-08-19 10:39:10 -04:00
Ludovic Marcotte 38713a6c67 (feat) handle multiple home/work phones, emails and urls 2015-08-18 16:21:47 -04:00
Ludovic Marcotte 20bf66d931 (feat) handle links to addressbooks like we do for calendars 
also included missing template commit for calendar
 2015-08-17 16:21:10 -04:00
Francis Lachapelle 9465fbad4b (obj-c) Indentation 2015-08-06 17:39:00 -04:00
Francis Lachapelle 0d537ab27b Return recurrence rules of occurrence 2015-08-06 16:15:12 -04:00
Francis Lachapelle 21f214659e (fix) Some compilation warnings 2015-08-03 12:16:16 -04:00
extrafu 393321b223 Merge pull request #92 from inverse-inc/feature/remove_colon 
Feature/remove colon
 2015-08-03 09:54:48 -04:00
Ludovic Marcotte f515106bcc (fix) added patch from PR93 2015-08-03 09:16:55 -04:00
Ludovic Marcotte 0c7bdac091 (fix) refactored code and we now return the unseenCount when fetching uids 2015-07-31 14:31:38 -04:00
Luc Charland 2f8f8c78f7 Removing colons 2015-07-31 14:14:30 -04:00
Ludovic Marcotte 0fc7c96924 (fix) use proper values for short/long date formats 2015-07-29 19:10:03 -04:00
Ludovic Marcotte 40dd3e5875 (fix) reworked c_ prefixes on givenname,cn,sn,o and component. 
This makes it easier to map to the quick table and avoid
fields duplications.
 2015-07-27 12:47:40 -04:00
Francis Lachapelle 538e6fa4b1 Add Chinese (Taiwan) translation 2015-07-23 12:08:04 -04:00
Francis Lachapelle c3aa601f3c (fix) Return value of [iCalPerson+SOGo uidInDomain:] 2015-07-23 12:07:57 -04:00
Francis Lachapelle 613f05ac02 Calendar module optimizations in multidomain setup 
Conflicts:
	NEWS
	UI/Common/UIxUserRightsEditor.m
 2015-07-23 12:06:54 -04:00
Francis Lachapelle 8f49778501 Fix .wod files for English and Basque 2015-07-23 12:03:45 -04:00
Francis Lachapelle f0b88811d6 Add Slovenian translation 2015-07-23 12:02:42 -04:00
Ludovic Marcotte 731264d9dc (fix) make sure ActiveSync is always usable with SQL-based auth sources 2015-07-22 10:14:03 -04:00
Ludovic Marcotte 8650492989 Applied PR90 as a patch due to too-many merge conflicts when cherry-picking 2015-07-22 09:05:17 -04:00
Ludovic Marcotte 4ab2c57903 (feat) handle priority and return receipt in mail editor (needs layout work) 2015-07-07 08:35:53 -04:00
Ludovic Marcotte 05d59df68b (feat) added mailbox delegation support 2015-07-03 20:40:06 -04:00
Francis Lachapelle 35ff82710a Handle attach URLs in appointment editor 2015-07-01 15:00:12 -04:00
Francis Lachapelle ba5f6410ed Return recurrence rule only if frequency is known 2015-07-01 14:11:53 -04:00
Francis Lachapelle 69424be245 Return attributes of iCalEntity if non-empty 
Only include classification and status if theyr are not empty.
 2015-06-25 11:17:53 -04:00
Francis Lachapelle 8402152a59 Load alarm from UIxComponentEditor 
The alarm attributes are now loaded from UIxComponentEditor and not
iCalEntityObject so we can determine if the component's owner is part of
the alarm's attendees.
 2015-06-22 09:20:35 -04:00
Francis Lachapelle d89f02ff53 Change signature of [iCalAlarm alarmForEvent:..] 
The first argument doesn't have to be a iCalRepeatableEntity; a simple
iCalEntity is enough.
 2015-06-19 22:08:08 -04:00
Ludovic Marcotte e65ff2105e Revert "(fix) ensure calendar objects have a (fake) filename" 
This reverts commit a145fdbb53.
 2015-06-17 15:57:53 -04:00
Ludovic Marcotte 406e9a3df2 (fix) dropped old calendar sync/tag properties 2015-06-15 10:05:39 -04:00
Francis Lachapelle 3350e2fa12 (fix) Syntax of word "occurrence" 2015-06-12 12:03:52 -04:00
Francis Lachapelle 33b035b360 LDIF to vCard: Handle multiple emails & phones 2015-06-12 11:58:59 -04:00
Ludovic Marcotte d581054214 (fix) fixed default values for many prefs 2015-06-12 11:45:09 -04:00
Ludovic Marcotte 772a682655 (fix) correctly localize mail labels from common bundle 2015-06-12 11:43:52 -04:00
Francis Lachapelle 516e5fd303 Add current date in top bar 2015-06-12 11:35:54 -04:00
Ludovic Marcotte 0f2e3df164 More cleanups, defaults values for mail/contact/calendar labels and data validation 2015-06-12 11:35:51 -04:00
Ludovic Marcotte 96d2a4cea8 Preferences saving support 2015-06-12 11:27:17 -04:00
Francis Lachapelle 8d003a7c35 Return used space of quota as a number in JSON 2015-06-12 11:22:45 -04:00
Francis Lachapelle 94105e937a Improve JSON getter/setter for todos 2015-06-12 10:50:03 -04:00
Francis Lachapelle f47a22068f JSON: fix handling of dates of all-day events 2015-06-12 10:50:03 -04:00
Francis Lachapelle 177c933af4 Lowercase the status property of vEvent & vToDo 2015-06-12 10:50:02 -04:00
Francis Lachapelle bbc5a2a048 Fix compilation warning of SOGoAppointmentObject.m 2015-06-12 10:50:02 -04:00
Francis Lachapelle 4ddf92aadb JSON: Return ISO8601 dates in calendar components 2015-06-12 10:50:01 -04:00
Francis Lachapelle e226825bde Add [NSCalendarDate+SOGo iso8601DateString] 2015-06-12 10:50:01 -04:00
Francis Lachapelle f9271b747c Initial JSON actions to get/set an event 2015-06-12 10:48:00 -04:00
Francis Lachapelle 221e49a5d1 Improve [iCalTrigger asDictionary] 2015-06-11 15:57:26 -04:00
Francis Lachapelle 862068eeb5 Improve JSON getters for events 2015-06-11 15:56:59 -04:00
Francis Lachapelle 80785304f1 JSONify [UIxCalendarProperties saveAction] 2015-06-11 15:56:31 -04:00
Francis Lachapelle 137e8e7290 Add [iCal(Repeatable)EntityObject attribtues] 
Those methods are used to get the common attributes of a iCalendar
component (vEvent or vTodo).
 2015-06-11 15:54:07 -04:00
Francis Lachapelle ad012cfd60 Save message to IMAP server before saving plist 
By first appending the message to the mailbox, we obtain the IMAP ID and
save it to the local plist. Having the message ID, we can delete it when
saving/appending a new version of the draft to the mailbox.
 2015-06-11 15:49:18 -04:00
Francis Lachapelle 2d076358d3 Improve Mail module 
- JSONinfied mail folder create and delete actions
- restored sgFolderTree directive
- extended folder types with "shared" and "otherUsers"
- added mailbox creation at the account level
 2015-06-11 15:48:14 -04:00
Francis Lachapelle 9e97c11401 Don't store draft on disk when not required 2015-06-11 15:42:33 -04:00
Francis Lachapelle ac06a4d4ce Fix detection of mailbox type 2015-06-11 15:40:26 -04:00
Francis Lachapelle 6d899008ca Improve SOGoDraftObject to avoid crash when saving 2015-06-11 15:40:25 -04:00
Francis Lachapelle 4e9a187c85 Fix resolution of mailboxes with a special purpose 2015-06-11 15:40:24 -04:00
Francis Lachapelle 2f17e94fef Initial AngularJS version of Webmail (desktop) 2015-06-11 15:40:22 -04:00
Francis Lachapelle e5ce053a62 Convert allFoldersMetadata to a tree structure 
When parsing the mailboxes list, we now generated a hierarchical
structure of the metadata. Each mailbox (a dictionary) can now have a
'children' key that is an array of mailboxes.
 2015-06-11 15:40:20 -04:00
Ludovic Marcotte e964496759 Revert "Added required patch for previous commit" 
This reverts commit 18a363a07b.
 2015-06-11 15:38:15 -04:00
Francis Lachapelle bb9e8c0348 Remove trailing slash from template theme name 2015-06-11 15:26:38 -04:00
Francis Lachapelle e40b42c213 Move setAttributes from NGVCard to UIx*Editors 2015-06-11 15:26:35 -04:00
Francis Lachapelle c0eac04437 Adapt SOGoContactGCSFolder contact representation 
To match [UIxContactViewer dataAction].
 2015-06-11 15:25:29 -04:00
Francis Lachapelle a07d918fbf Add category to CardElement 
New method to return a JSON representation of the element.
 2015-06-11 15:25:27 -04:00
Francis Lachapelle 77b80e27c6 Add support for themes 2015-06-11 15:25:24 -04:00
Francis Lachapelle 0a49031b01 JSON-based operations on contacts 2015-06-11 15:23:27 -04:00
Ludovic Marcotte 5ad3662640 (fix) fixed multi-domain support for sogo-tool backup/restore (#2600) 2015-06-11 13:32:57 -04:00
Francis Lachapelle a70ea38572 New method [NSString+Utilities asSafeJSString] 2015-06-11 11:44:17 -04:00
Ludovic Marcotte 5e66e8e299 (fix) improvement over previous commit to avoid double-bind 2015-06-11 11:36:03 -04:00
Ludovic Marcotte d9896192f3 Revert "Revert "Improve creation of CSS identifier"" 
This reverts commit 7d018221ef.
 2015-06-10 20:05:40 -04:00
Ludovic Marcotte 85ad849189 Revert "Revert "Improved rationale"" 
This reverts commit 6994c029b8.
 2015-06-10 20:05:13 -04:00